Skip to content

COMP: Use @ref for module Doxygen cross-refs to silence CMP0219 - #6857

Merged
hjmjohnson merged 1 commit into
InsightSoftwareConsortium:release-5.4from
dzenanz:cmp0219rel
Sep 11, 2026
Merged

COMP: Use @ref for module Doxygen cross-refs to silence CMP0219#6857
hjmjohnson merged 1 commit into
InsightSoftwareConsortium:release-5.4from
dzenanz:cmp0219rel

Conversation

@dzenanz

@dzenanz dzenanz commented Sep 10, 2026

Copy link
Copy Markdown
Member

Backport of #6668 to 5.4 release.

PR Checklist

CMake 4.4 policy CMP0219 warns when a macro (itk_module) receives
arguments containing backslashes. The module DESCRIPTION strings carried
Doxygen \ref group cross-references, spelled \\\\ref so a literal \ref
survived the macro re-parse. Doxygen treats @ref identically to \ref,
and @ is inert to both the macro and configure_file @only, so switching
to @ref removes the warning on every CMake version while keeping the
generated Module.dox cross-links byte-for-byte unchanged.

Ref: InsightSoftwareConsortium#6660
@github-actions github-actions Bot added type:Compiler Compiler support or related warnings area:Filtering Issues affecting the Filtering module area:Registration Issues affecting the Registration module area:Segmentation Issues affecting the Segmentation module labels Sep 10, 2026
@greptile-apps

greptile-apps Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Summary

This change updates module-documentation cross-references in Filtering, Registration, and Segmentation metadata. The new command spelling conflicts with the repository’s required Doxygen style and must be corrected before merging.

Confidence Score: 4/5

Not merge-safe until the repository’s required Doxygen command style is restored.

The final review contains one repository-rule violation and no higher-impact findings.

Files Needing Attention: Modules/Filtering/AnisotropicSmoothing/itk-module.cmake and the other changed module metadata files using @ref.

Reviews (1): Last reviewed commit: "COMP: Use @ref for module Doxygen cross-..." | Re-trigger Greptile

Comment thread Modules/Filtering/AnisotropicSmoothing/itk-module.cmake
@hjmjohnson
hjmjohnson merged commit 083655a into InsightSoftwareConsortium:release-5.4 Sep 11, 2026
17 checks passed
@dzenanz
dzenanz deleted the cmp0219rel branch September 11, 2026 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:Filtering Issues affecting the Filtering module area:Registration Issues affecting the Registration module area:Segmentation Issues affecting the Segmentation module type:Compiler Compiler support or related warnings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants