This repository was archived by the owner on May 27, 2026. It is now read-only.
ENH: Add (not)wrapping for Iterator-like classes.#63
Merged
phcerdan merged 1 commit intoAug 20, 2017
Merged
Conversation
Member
Author
|
Follow-up of comment on Iterator-like classes in issue #56. |
Collaborator
|
@jhlegarreta Probably doesn't matter, but maybe for consistency we can follow the existing notwrapping style for iterators: |
Member
Author
|
@phcerdan Yes, I was in two minds when doing this, but @thewtex recommended in #56 to add
But it is highly likely that I misinterpreted what he meant. Matt, does what I did match what you expected, or else, should I change to/add the exiting convention for (not)wrapping iterators? Thanks. |
Member
|
It may be clearer to have the file contents only as and also fix itkImageConstIteratorWithIndex.notwrapped. |
ITK iterator class wrapping has no use, but corresponding files with .notwrapped extension are added with a message warning about it are added so that developers know about this.
jhlegarreta
force-pushed
the
AddIteratorClassesWrapping
branch
from
August 17, 2017 15:13
b29da8c to
25786a4
Compare
Member
Author
|
Done. Submitted a topic to gerrit for |
kwrobot
referenced
this pull request
in Kitware/ITK
Sep 12, 2017
Following a discussion on wrapping ITK iterators on a remote module, https://github.com/phcerdan/ITKIsotropicWavelets/pull/63 Matt suggested changing the itk::ImageConstIteratorWithIndex wrapping to display an error message only. This patch set changes the the Iterator classes' *.notwrapped files to contain only an error message. Change-Id: I9c7d20ef6d07f7af66600966acfc5a92fce3ddf7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ITK iterator class wrapping has no use, but corresponding files with
.notwrapped extension are added with a message warning about it are added
so that developers know about this.