BUG: Fix keyword param point_set -> point_sets

[bnmajor]

No description provided.

[review-notebook-app]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[thewtex]

I think this should be point_set -- so adjustments may need to be made to the view code?

In 0.X, we could pass a list of point sets (and geometries), however in 1.X, I would like to support a single point set and geometry for view because it avoids ambiguities with NumPy-derived data types and lists and it provide a more reasonable way to specify parameters -- they can just be passed as kwargs to view. To add more data the scene, viewer = view(point_set1); viewer.add_point_set(point_set2) Does that make sense?

[bnmajor]

@thewtex Makes sense! I'll just update this PR to make those fixes instead

[bnmajor]

@thewtex Any preference on the default behavior for detecting the input type for numpy arrays, zarr groups, dask arrays, PyTorch tensors, or xarray DataArrays or Datasets? In all of these cases the default is to treat the data as an image if not explicitly passed in with the point_set kwarg. So for your example viewer = view(point_set1) this would (for most data types) be treated as an image without point_set keyword.

Also right now the behavior in the itk-vtk-viewer api is to overwrite the existing point set rather than update the list. I could either update setPointSets to append the new data, or maybe it would make more sense to add a new function like updatePointSets or appendPointSet?

[thewtex]

@bnmajor thanks!

@thewtex Any preference on the default behavior for detecting the input type for numpy arrays, zarr groups, dask arrays, PyTorch tensors, or xarray DataArrays or Datasets? In all of these cases the default is to treat the data as an image if not explicitly passed in with the point_set kwarg. So for your example viewer = view(point_set1) this would (for most data types) be treated as an image without point_set keyword.

In detecting the type without an explicit kwarg, can we have Nx3 (x,y,z) or Nx2 (x,y) imply point set, and image otherwise?

Also right now the behavior in the itk-vtk-viewer api is to overwrite the existing point set rather than update the list. I could either update setPointSets to append the new data, or maybe it would make more sense to add a new function like updatePointSets or appendPointSet?

Thinking about transitions, addPointSet would be ideal.

[thewtex]

unrelated to your changes here, but can we please fix regardless: Point_Set -> PointSet 🙏

[bnmajor]

Fixed!

[bnmajor]

In detecting the type without an explicit kwarg, can we have Nx3 (x,y,z) or Nx2 (x,y) imply point set, and image otherwise?

Sure thing! Updated with those changes now 👍

Thinking about transitions, addPointSet would be ideal.

Awesome. This branch now relies on Kitware/itk-vtk-viewer#643. Once that is in the itk-vtk-viewer version will need to be bumped before this branch is ready.

[thewtex]

🥇 💯