chore(deps): bump waveflow-core rev to pick up t.album_id projection - #39
Merged
Conversation
Closes the legacy `/tracks` collection's NULL projection asymmetry.
WaveFlow desktop PR #209 swapped every `NULL::bigint AS album_id`
in `PostgresTrackRepository::{list,get,insert,update}_for_library`
for the real `t.album_id` column; this PR picks it up by bumping
the `waveflow-core` git rev in Cargo.toml to the merged commit.
Refreshes the `TrackResponse.album_id` doc comment to drop the
"a follow-up bumps core" caveat — the follow-up is this PR.
No schema change, no behavior change beyond the wire shape now
carrying the real FK on the legacy collection (it already carried
it on the album drill-down). Existing integration tests don't
assert on `album_id`, so the rev bump is transparent to the
existing suite.
Signed-off-by: InstaZDLL <github.105mh@8shield.net>
Owner
Author
|
@coderabbitai review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes the legacy `/tracks` collection's NULL-projection asymmetry that was explicitly tracked in this repo's CLAUDE.md + the desktop's `project_sprint_4_web_progress.md` follow-ups.
WaveFlow PR #209 swapped every `NULL::bigint AS album_id` in `PostgresTrackRepository::{list,get,insert,update}_for_library` for the real `t.album_id` column. This PR picks it up by bumping the `waveflow-core` git rev in `Cargo.toml` to the merged commit `60550e1`.
The doc comment on `TrackResponse.album_id` (in `src/api/tracks.rs`) loses the "a follow-up bumps core" caveat — the follow-up is this PR.
Test plan
Behavior
No schema change. The wire shape on `GET /api/v1/profiles/{p}/libraries/{l}/tracks` now carries the real FK in `album_id` for materialised rows (it was always `null` before — the column existed in the response but the SELECT projected NULL). Drill-down endpoints (`/albums/{id}/tracks` + `/artists/{id}/tracks`) already carried the real value; the legacy collection now matches.
Diff
3 files, 8 +/- 11: