Add cell deselection API

[rnystrom]

Changes in this pull request

Adding support for a cell deselection API. Trying to make some headway to move and drag+drop support, but also want better stock UICollectionView API support. Will also assist eventual UITableView support.

• Added overridable API to IGListSectionController
• Support for stacked SC
• Breaking, required protocol for binding SC

Assists #524 and #184

Checklist

• All tests pass. Demo project builds and runs.
• I added tests, an experiment, or detailed why my change isn't tested.
• I added an entry to the CHANGELOG.md for any breaking changes, enhancements, or bug fixes.

[weyert]

Looks alright to me. I see you made a default implementation for this method

[facebook-github-bot]

@rnystrom updated the pull request - view changes

[jessesquires]

3.1.0 cannot contain breaking changes according to SemVer, we'll need to make this 4.0.0. 😊

I think this is fine though. People tend to freak out about version numbers, I don't think it's a big deal. What's important is communicating changes + proper SemVer.

Looks like there's a handful of things in the 3.1.0 milestone that we could wrap up -- we could merge those and this, rename to 4.0 and push a release. The current 4.0 would then get bumped to 5.0.

Thoughts?

cc @amonshiz

[rnystrom]

@jessesquires TIL! Another option: I could make this with @optional then remove for 4.0? Not opposed to a bigger 4.0 release either.

Or maybe I hold off on this, land some internal changes + fixes (I have some diffs up inside), release 3.1, then land + prep 4.0?

edit: The @optional would only effect IGListBindingSectionController which is a small part of this feature

[amonshiz]

i'm fine bumping table view support to 5.0

[jessesquires]

@rnystrom -- either of those sound good to me.

RE: 4.0 release -- We could just merge this and immediately push 4.0, then anything else goes into 4.1. I was just thinking, since we have some low-hanging fruit, we could include more in a 4.0 release to make it "more worth it"

[rnystrom]

Ya I'd rather package a bit more into the 4.0 since semantically its kind of a big deal. Atm there's barely anything compared to 3.0.

I lean towards @optional and then remove that for 4.0

[facebook-github-bot]

@rnystrom updated the pull request - view changes

[amonshiz]

i thought swift didn't support @optional which is why there has been a push internally to remove all @optional protocol methods and properties.

[rnystrom]

Still supports it, discouraged b/c of how it will silently break things

https://useyourloaf.com/blog/swift-optional-protocol-methods/

[rnystrom]

Importing for eyeballs

[facebook-github-bot]

@rnystrom has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[jessesquires]

@rnystrom sounds good to me 👍

let's make sure we create a 4.0 task to remove @optional