fix(cluster): enable ArgoCD Progressive Syncs on the ApplicationSet controller - #55
Draft
nbrieussel wants to merge 1 commit into
Draft
fix(cluster): enable ArgoCD Progressive Syncs on the ApplicationSet controller#55nbrieussel wants to merge 1 commit into
nbrieussel wants to merge 1 commit into
Conversation
…yncs Without --enable-progressive-syncs, the argocd.argoproj.io/sync-wave annotation on Applications generated by an ApplicationSet does nothing — each is created and auto-synced independently, no ordering across them. Confirmed live 2026-08-11: this let Velero/external-dns/Dex/Grafana race OpenBao's restore on a fresh cluster boot even after moving them into the ApplicationSet-driven graph (gitops PR #24). services-app-scaleway (bootstrap/templates/scaleway.yaml in the gitops repo) now uses a RollingSync strategy that needs this flag to actually enforce ordering. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017ZMCuQ5t9hdrmUctLk7hEv
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
services-app-scalewayApplicationSet graph so their sync-wave would be coordinated against the-init/-configapps that produce their OpenBao-backed Secrets.sync-waveannotations on Applications generated by an ApplicationSet are inert — each generated Application is created and auto-synced independently, with no cross-Application ordering, unlike the classic app-of-apps pattern (a single parentApplicationmanaging children as its own resources) where sync-wave genuinely is honored.applicationSet.extraArgs: [--enable-progressive-syncs]to the ArgoCD Helm release, required for gitops'sservices-app-scalewayApplicationSet to use aRollingSyncstrategy (label-based grouping, not annotation-based) that actually gates group N+1 on group N being Healthy.Test plan
terraform applyon10-cluster/scaleway, confirm the ArgoCD Helm release upgrades cleanly (applicationset-controller pod restarts with the new arg)services-app-scaleway's generated Applications now roll out wave-by-wave (kubectl get application -n argocd -l wave=<N>) instead of all racing at once🤖 Generated with Claude Code
https://claude.ai/code/session_017ZMCuQ5t9hdrmUctLk7hEv