Replace deprecated nd_item::barrier() with sycl::group_barrier() in accumulators and gemm kernels#3006
Merged
Merged
Conversation
antonwolfy
requested review from
ndgrigorian and
vlad-perevezentsev
as code owners
July 22, 2026 15:55
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
Contributor
|
Array API standard conformance tests for dpnp=0.21.0dev3=py314h509198e_14 ran successfully. |
Collaborator
|
coverage: 78.386%. remained the same — address-deprecation-warning into master |
vlad-perevezentsev
approved these changes
Jul 23, 2026
vlad-perevezentsev
left a comment
vlad-perevezentsev
left a comment
Contributor
There was a problem hiding this comment.
LGTM
Thank you @antonwolfy
github-actions Bot
added a commit
that referenced
this pull request
Jul 23, 2026
…in accumulators and gemm kernels (#3006) The Intel DPC++ compiler (starting with the 2026.2.0) emits a deprecation warning for the `nd_item::barrier()` member function: > warning: 'barrier' is deprecated: use sycl::group_barrier() free function > instead [-Wdeprecated-declarations] Notes on correctness: - `nd_item::barrier()` is a **work-group** barrier, so it maps to `group_barrier(it.get_group(), …)`, not a sub-group barrier. The surrounding code depends on work-group-wide synchronization of shared-local-memory buffers. - The old `fence_space::local_space` argument controlled *which memory* was fenced (local only). `group_barrier`'s optional argument is instead a `memory_scope`; the chosen `work_group` scope fences both local and global memory across the work-group — a superset of the previous behavior, so it is strictly safe. On the target Intel devices a work-group barrier lowers to the same hardware barrier regardless, so there is no performance impact. This PR replaces the deprecated member function to use of `sycl::group_barrier()`. e5b5154
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Intel DPC++ compiler (starting with the 2026.2.0) emits a deprecation warning for the
nd_item::barrier()member function:Notes on correctness:
nd_item::barrier()is a work-group barrier, so it maps togroup_barrier(it.get_group(), …), not a sub-group barrier. The surrounding code depends on work-group-wide synchronization of shared-local-memory buffers.fence_space::local_spaceargument controlled which memory was fenced (local only).group_barrier's optional argument is instead amemory_scope; the chosenwork_groupscope fences both local and global memory across the work-group — a superset of the previous behavior, so it is strictly safe. On the target Intel devices a work-group barrier lowers to the same hardware barrier regardless, so there is no performance impact.This PR replaces the deprecated member function to use of
sycl::group_barrier().