-
Notifications
You must be signed in to change notification settings - Fork 20
Drop support for Python 3.9 #243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes Python 3.9 support from mkl_fft, aligning with NumPy's deprecation of this Python version. The changes update package metadata and CI/CD configurations to reflect the new minimum supported version of Python 3.10.
- Removed Python 3.9 from package classifiers and version requirements
- Updated all CI/CD workflows to exclude Python 3.9 from test matrices
- Removed conditional logic specific to Python 3.9 compatibility issues
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pyproject.toml | Removed Python 3.9 classifier and updated minimum required version to 3.10 |
| .github/workflows/conda-package.yml | Removed Python 3.9 from test matrices and eliminated conditional scipy installation logic |
| .github/workflows/conda-package-cf.yml | Removed Python 3.9 entries from test matrix configurations |
| .github/workflows/build_pip.yaml | Removed Python 3.9 from build test matrix |
| .github/workflows/build-with-clang.yml | Removed Python 3.9 from clang build test matrix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
68e1a41 to
35f3cb3
Compare
5906c4c to
f937387
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @ndgrigorian
|
@antonwolfy |
This PR proposes dropping Python 3.9 support from mkl_fft, as it has long been unsupported by NumPy