Skip to content

Conversation

@ndgrigorian
Copy link
Collaborator

This PR proposes dropping Python 3.9 support from mkl_fft, as it has long been unsupported by NumPy

Copilot AI review requested due to automatic review settings October 29, 2025 20:36
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes Python 3.9 support from mkl_fft, aligning with NumPy's deprecation of this Python version. The changes update package metadata and CI/CD configurations to reflect the new minimum supported version of Python 3.10.

  • Removed Python 3.9 from package classifiers and version requirements
  • Updated all CI/CD workflows to exclude Python 3.9 from test matrices
  • Removed conditional logic specific to Python 3.9 compatibility issues

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
pyproject.toml Removed Python 3.9 classifier and updated minimum required version to 3.10
.github/workflows/conda-package.yml Removed Python 3.9 from test matrices and eliminated conditional scipy installation logic
.github/workflows/conda-package-cf.yml Removed Python 3.9 entries from test matrix configurations
.github/workflows/build_pip.yaml Removed Python 3.9 from build test matrix
.github/workflows/build-with-clang.yml Removed Python 3.9 from clang build test matrix

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Collaborator

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ndgrigorian

@ndgrigorian
Copy link
Collaborator Author

@antonwolfy
your thanks are appreciated, but an approval would be even more :)

@ndgrigorian ndgrigorian merged commit dd0cdd0 into master Nov 3, 2025
41 of 45 checks passed
@ndgrigorian ndgrigorian deleted the drop-python-3.9 branch November 3, 2025 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants