Skip to content

fix: global palette is not really any more#3448

Open
dordsor21 wants to merge 3 commits intomainfrom
fix/global-palette-kinda-is-not
Open

fix: global palette is not really any more#3448
dordsor21 wants to merge 3 commits intomainfrom
fix/global-palette-kinda-is-not

Conversation

@dordsor21
Copy link
Member

Overview

Fixes #{issue number}

Description

Submitter Checklist

  • Make sure you are opening from a topic branch (/feature/fix/docs/ branch (right side)) and not your main branch.
  • Ensure that the pull request title represents the desired changelog entry.
  • New public fields and methods are annotated with @since TODO.
  • I read and followed the contribution guidelines.

@dordsor21 dordsor21 requested a review from a team as a code owner February 1, 2026 10:28
@github-actions github-actions bot added the Bugfix This PR fixes a bug label Feb 1, 2026
@NotMyFault NotMyFault requested a review from a team February 1, 2026 10:32
@MrJoshuaT
Copy link
Contributor

MrJoshuaT commented Feb 1, 2026

I've just built and ran a quick test, which uses the 1_21_11 adapter, and it's throwing a few errors around Failed to read PalettedContainer and Use of an uninitialized palette. Although it did seem to paste correctly in-game (that I can see) it fails to undo throwing Use of an uninitialized palette

Pasting: https://mclo.gs/1aph6Tp
Undo: https://mclo.gs/764r4bR

@dordsor21
Copy link
Member Author

I've just built and ran a quick test, which uses the 1_21_11 adapter, and it's throwing a few errors around Failed to read PalettedContainer and Use of an uninitialized palette

https://mclo.gs/1aph6Tp

Hm, worked when I tested... Will try again

@dordsor21
Copy link
Member Author

I've just built and ran a quick test, which uses the 1_21_11 adapter, and it's throwing a few errors around Failed to read PalettedContainer and Use of an uninitialized palette. Although it did seem to paste correctly in-game (that I can see) it fails to undo throwing Use of an uninitialized palette

Pasting: mclo.gs/1aph6Tp Undo: mclo.gs/764r4bR

This should be fixed

@dordsor21 dordsor21 linked an issue Feb 1, 2026 that may be closed by this pull request
@MrJoshuaT
Copy link
Contributor

I've just built and ran a quick test, which uses the 1_21_11 adapter, and it's throwing a few errors around Failed to read PalettedContainer and Use of an uninitialized palette. Although it did seem to paste correctly in-game (that I can see) it fails to undo throwing Use of an uninitialized palette
Pasting: mclo.gs/1aph6Tp Undo: mclo.gs/764r4bR

This should be fixed

Built and tested again. Look good, no errors in console when doing paste, undo or redo. Build looks correctly pasted in the world.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bugfix This PR fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deletes Parts Of Build When Copy And Pasting

3 participants