Chapter15 regions #288
Merged
Chapter15 regions #288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minor changes from pdf review Chapter 13 first changes Chapter 12 Regions through 12.6 Reviewed through 12.4 Changes from pdf review Changes from pdf review Minor changes from pdf review Chapter 14 initial changes chapter 14 code changes Changes from pdf review Minor changes from pdf review Chapter 15 initial changes chapter 13 review changes adding ... to beginning and end minor ch. 15 changes preventing line rollovers ch. 14 final (hopefully) ch. 14 changes Final ch. 15 changes chapter 15 formatting changes chapter 15 removing redundancies Revert "Changes from pdf review" This reverts commit e114c2c. Revert "Minor changes from pdf review" This reverts commit 47d535e. Revert "Chapter 13 first changes" This reverts commit b211cf3.
BenjaminMichaelis
requested changes
Jul 5, 2022
Member
BenjaminMichaelis
left a comment
BenjaminMichaelis
left a comment
There was a problem hiding this comment.
This looks good overall! Just some minor changes and adjustments from my end
src/Chapter14/Listing14.01.HeaterAndCoolerEventSubscriberImplementations.cs
Outdated
Show resolved
Hide resolved
src/Chapter14/Listing14.01.HeaterAndCoolerEventSubscriberImplementations.cs
Outdated
Show resolved
Hide resolved
src/Chapter14/Listing14.02.DefiningTheEventPublsherThermostat.cs
Outdated
Show resolved
Hide resolved
src/Chapter14/Listing14.03.ConnectingThePublisherAndSubscribers.cs
Outdated
Show resolved
Hide resolved
src/Chapter14/Listing14.07.UsingthePlusEqualsAndMinusEqualsDelegateOperators.cs
Outdated
Show resolved
Hide resolved
src/Chapter15/Listing15.20.AnotherInnerJoinWithSystem.Linq.Enumerable.Join.cs
Outdated
Show resolved
Hide resolved
src/Chapter15/Listing15.22.CreatingAChildCollectionWithSystem.Linq.Enumerable.GroupJoin.cs
Outdated
Show resolved
Hide resolved
src/Chapter15/Listing15.22.CreatingAChildCollectionWithSystem.Linq.Enumerable.GroupJoin.cs
Outdated
Show resolved
Hide resolved
Keboo
reviewed
Jul 6, 2022
Keboo
reviewed
Jul 6, 2022
Co-authored-by: Kevin B <Keboo@users.noreply.github.com>
…ble.Join.cs Co-authored-by: Benjamin Michaelis <benjamin@michaelis.net>
…merable.Join.cs Co-authored-by: Benjamin Michaelis <benjamin@michaelis.net>
Collaborator
Author
|
I've updated and changed everything that I know how. There are still errors in 14.19 and 15.13 that are blocking the checks but I don't know how to fix them. |
Member
|
Perfect! I will try to get those errors fixed and review the remaining comments |
BenjaminMichaelis
approved these changes
Jul 6, 2022
Member
|
Thanks @HannaMichaelis! I'll |
now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Contributes to Intellitect/EssentialCSharpManuscript#116