Converted snippets to listings in Ch 9 #501
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Do you know how to point the word documents in the tooling repo to this commit so we can make sure the word doc parses? @Keboo i would think it probably doesn't hurt to run this commit through the tooling? Thoughts? |
Member
|
@BenjaminMichaelis we already know it is going to fail when the word document runs through it. We tested locally and there will need to be document changes to go along with this. So this PR is going to sit until those get done. |
Keboo
reviewed
Jul 25, 2023
src/Chapter09.Tests/Listing09.06.EquivalentRecordClassCode.Tests.cs
Outdated
Show resolved
Hide resolved
src/Chapter09.Tests/Listing09.15.RecordDeconstructorsAndPatternMatching.Tests.cs
Outdated
Show resolved
Hide resolved
src/Chapter09/Listing09.20.ImplementingValueEqualityOnCustomTypes.cs
Outdated
Show resolved
Hide resolved
src/Chapter09/Listing09.22.OverridingGetHashCodeUsingCombine.cs
Outdated
Show resolved
Hide resolved
src/Chapter09/Listing09.22.OverridingGetHashCodeUsingCombine.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Kevin B <Keboo@users.noreply.github.com>
Co-authored-by: Kevin B <Keboo@users.noreply.github.com>
…ts.cs Co-authored-by: Kevin B <Keboo@users.noreply.github.com>
Co-authored-by: Kevin B <Keboo@users.noreply.github.com>
…nMatching.Tests.cs Co-authored-by: Kevin B <Keboo@users.noreply.github.com>
Co-authored-by: Kevin B <Keboo@users.noreply.github.com>
Co-authored-by: Kevin B <Keboo@users.noreply.github.com>
Keboo
reviewed
Aug 1, 2023
Changed a few pieces of code to more accurately match what the book originally had
Keboo
reviewed
Aug 2, 2023
…bine.Tests.cs Co-authored-by: Kevin B <Keboo@users.noreply.github.com>
Co-authored-by: Kevin B <Keboo@users.noreply.github.com>
Co-authored-by: Kevin B <Keboo@users.noreply.github.com>
Co-authored-by: Kevin B <Keboo@users.noreply.github.com>
…raceBuffers.Tests.cs Co-authored-by: Kevin B <Keboo@users.noreply.github.com>
…bine.Tests.cs Co-authored-by: Kevin B <Keboo@users.noreply.github.com>
…ueTuples.Tests.cs Co-authored-by: Kevin B <Keboo@users.noreply.github.com>
Closed
danOIntellitect
approved these changes
Aug 9, 2023
Contributor
danOIntellitect
left a comment
danOIntellitect
left a comment
There was a problem hiding this comment.
LGTM as long as those comments that Kevin left were addressed. Let me know if the comments from him don't make sense
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.