Added sample for Covariant Return Types (7.11) #519
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keboo
reviewed
Aug 20, 2023
Member
Keboo
left a comment
Keboo
left a comment
There was a problem hiding this comment.
Did you mean to edit things across 4 chapters here? The title of this PR suggests only the chap 7 changes are expected.
Member
Author
|
@Keboo: Sort of... I renumbered things in Chapter 7 and then did a multi-chapter change that modified Chapter 7. To avoid a nasty merge with multiple file changes and numerous file name changes, did one change on top of the other. There are separate branches if that is easier, but the one branch builds on the other. |
Keboo
approved these changes
Aug 23, 2023
Co-authored-by: Benjamin Michaelis <benjamin@michaelis.net>
MarkMichaelis
commented
Aug 26, 2023
MarkMichaelis
commented
Aug 26, 2023
Co-authored-by: Kevin B <Keboo@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.