Doing some renaming #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding in an overload for ignoring 5 exception types
This was referenced Dec 10, 2018
Closed
Keboo
reviewed
Dec 10, 2018
| <PackageTags>ui test, automated test, testing, api test, web test, integration test, await, async</PackageTags> | ||
| <PackageReleaseNotes>Initial release for long-term home, independant from Selenium dependency</PackageReleaseNotes> | ||
| <PackageReleaseNotes>Function rename to get away from Selenium terminology, and to use a more generic (but accurate) name for what the functions do (new terminology: Poll.UntilNoExceptions) | ||
| Obsoleting old Wait.Until terminology</PackageReleaseNotes> |
Member
There was a problem hiding this comment.
Something I have done on my OSS project is to make this a URL to a .md file or wiki page on the repo. Then I can easily update the release notes without needing to spin a new NuGet package.
Keboo
approved these changes
Dec 10, 2018
…ject to use for replicating functionality we want to test for
Keboo
reviewed
Dec 12, 2018
|
|
||
| private int _Attempts = 0; | ||
| private TimeSpan _Timeout = TimeSpan.MinValue; | ||
| private Stopwatch _Sw = new Stopwatch(); |
Member
There was a problem hiding this comment.
I think there are a couple of logic errors here.
- These fields only appear to be used inside of the ThrowExceptions method. By keeping them as fields instead of local variables inside of the method it means you are keeping the state around. Meaning subsequent calls to this method are dependant of previous calls. If this is not intended I would move them inside of the method.
- This does not actually start a stopwatch. In the
ThrowExceptionsyou do start it on the first pass, but then you never Stop/Restart the stop watch. Meaning that you might never get inside of the while loop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding in an overload for ignoring 5 exception types
Adding in a new class with a more generic, but more descriptive, name for the provided functionality
Obsoleted old Wait.Until terminology
Adding/tweaking some unit tests to be more reliable