Skip to content

Deprecating IntelliWait in favor of Polly #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 17, 2019
Merged

Deprecating IntelliWait in favor of Polly #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f526070
Deprecating IntelliWait in favor of Polly
PandaMagnus Mar 27, 2019
34c8dc8
Updating csproj for correct semver
PandaMagnus Jul 16, 2019
f73c365
Removing problematic test since we're deprecating anyway
PandaMagnus Jul 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions IntelliTect.IntelliWait.Tests/UnExpectedExceptionsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,14 +78,6 @@ await Assert.ThrowsAsync<IndexOutOfRangeException>(
() => Test.CheckExceptionsVoidReturn(1, 3), TimeSpan.FromSeconds(2)));
}

[Fact]
public async Task CheckFuncGenericForThreeUnExpectedExpectionsThrows()
{
await Assert.ThrowsAsync<IndexOutOfRangeException>(
() => Poll.UntilNoExceptions<NullReferenceException, InvalidOperationException, InvalidProgramException>(
() => Test.CheckExceptionsBoolReturn(1, 3), TimeSpan.FromSeconds(2)));
}

[Fact]
public async Task CheckActionGenericForFourUnExpectedExpectionsThrows()
{
Expand Down
7 changes: 4 additions & 3 deletions IntelliTect.IntelliWait/IntelliTect.IntelliWait.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,15 +6,16 @@
<Authors>IntelliTect-Nuget; Mike Curn</Authors>
<Company>IntelliTect</Company>
<Description>Set of methods to facilitate waiting a certain amount of time for a delegate to evaluate, while ignoring certain exceptions while attempting to evaluate, and throwing after a specified time limit (or throwing immediately if an unexpected exception is encountered)</Description>
<PackageLicenseUrl>https://github.com/IntelliTect/IntelliTect/blob/master/LICENSE</PackageLicenseUrl>
<PackageLicenseUrl></PackageLicenseUrl>
<Copyright>Copyright © IntelliTect 2018</Copyright>
<PackageProjectUrl>https://github.com/IntelliTect/IntelliTect</PackageProjectUrl>
<RepositoryUrl>https://github.com/IntelliTect/IntelliTect</RepositoryUrl>
<RepositoryType>Git</RepositoryType>
<PackageTags>ui test, automated test, testing, api test, web test, integration test, await, async</PackageTags>
<PackageReleaseNotes>Function rename to get away from Selenium terminology, and to use a more generic (but accurate) name for what the functions do (new terminology: Poll.UntilNoExceptions)
Obsoleting old Wait.Until terminology</PackageReleaseNotes>
<PackageReleaseNotes>Obsoleting in favor of Polly</PackageReleaseNotes>
<AssemblyName>IntelliTect.IntelliWait</AssemblyName>
<Version>1.2.0</Version>
<PackageLicenseExpression>MIT</PackageLicenseExpression>
</PropertyGroup>
<ItemGroup>
<CodeAnalysisDictionary Include="CustomDictionary.xml" />
Expand Down
1 change: 1 addition & 0 deletions IntelliTect.IntelliWait/Poll.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

namespace IntelliTect.IntelliWait
{
[Obsolete("Deprecating in favor of Polly, which is a more robust and flexible polling library: https://github.com/App-vNext/Polly")]
public static class Poll
{
/// <summary>
Expand Down
2 changes: 1 addition & 1 deletion IntelliTect.IntelliWait/Wait.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

namespace IntelliTect.IntelliWait
{
[Obsolete("Deprecating Wait.Until() naming convention in favor of more accurate and descriptive Poll.UntilNoExceptions naming")]
[Obsolete("Deprecating in favor of Polly, which is a more robust and flexible polling library: https://github.com/App-vNext/Polly")]
public static class Wait
{
/// <summary>
Expand Down