Eliminate null values from MPN fields in JSON output#39
Merged
Conversation
Omit the mpn key entirely when MPN data is missing instead of emitting "mpn": null. The notes field already explains why MPN is unavailable, so the null value adds no information and wastes tokens. Changes: - types.ts: mpn fields changed from string | null to optional string - service.ts: conditional property assignment instead of null - pstxprt-parser.ts: parser no longer produces null MPN values - circuit-traversal.ts: internal types aligned - docs/: schemas and tool docs updated to reflect omission behavior - tests: assertions updated from toBeNull to toBeUndefined
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mpnkey entirely when MPN data is missing instead of emitting"mpn": nullnotesfield already explains why MPN is unavailable, so null values add no information and waste tokensTest plan
npm run type-checkpassesnpm run lintpassesnpm testpasses (299/299)