clarify: a calendar view adds a page; a document's line-items calendar is the items pane - #5
Open
delchev wants to merge 2 commits into
Open
clarify: a calendar view adds a page; a document's line-items calendar is the items pane#5delchev wants to merge 2 commits into
delchev wants to merge 2 commits into
Conversation
…r is the items pane `view: calendar` / `view: range` were described as rendering an entity "as a time-based page instead of a table", which read as - and was implemented as - replacing the entity's page family. That cost a document master its document editor: declaring a calendar took away the line items, printing and workflow tasks. State the additive rule instead. The entity keeps the pages its structure implies and the calendar joins them: /<Entity> is the calendar, /<Entity>/list the entity's own browse page, and create / edit stay the entity's own - so a document may be browsed on a calendar and still edited as a document. `view: slots` is called out as the exception, since a slot picker is an authoring surface rather than a second way to browse. Also document the line-items case: when the entity declaring `view: calendar` is a document's items child, the document's items pane IS the calendar - the shape for a day-grained line - and cannot also be a chat thread. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The previous revision carved `view: slots` out as the exception that still replaces the entity's browse page. That reasoning does not hold: a picker is how a record is CREATED, and the list or document page is how it is worked with afterwards - an author needs both, and a booking document lost its document editor exactly as a calendar-browsed one did. Generalise the rule to every view. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
view: calendar/view: rangewere described as rendering an entity "as a time-based page instead of a table". Read literally — and implemented literally — that replaces the entity's page family, which costs a document master its document editor: declaring a calendar took away the line items, printing and workflow tasks, so an author had to choose between the calendar and the document.This states the additive rule instead:
/<Entity>the calendar,/<Entity>/listthe entity's own browse page,create/editunchanged;view: slotsis called out as the exception, because a slot picker is an authoring surface (pick a free slot, create a record) rather than a second way to browse the same records.It also documents the line-items case, which had no wording at all: when the entity declaring
view: calendaris a document's items child, the document's items pane is the calendar — the shape for a day-grained line such as a booked day or an allocated hour — and cannot also be a chat thread, since the two claim the same pane.The
viewrow of the DSL index is reworded to match.Reference implementation: eclipse-dirigible/dirigible#6624 (issues #6547 and #6482 there). The website chapter follows in IntentFile/intentfile.github.io.