update embedding v2 snake case#64
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request standardizes the naming convention for the embedding V2 method across the codebase by renaming
embeddingV2toembedding_v2. This change ensures consistency and clarity in both method definitions and usage.Naming consistency improvements:
embeddingV2toembedding_v2in theGeneralclass, including all overloads and the implementation, insrc/general/index.ts.Generalclass constructor to use the newembedding_v2method name insrc/general/index.ts.embeddingV2toembedding_v2in the returned object of theJigsawStackfunction insrc/core.ts.