Update CLHS reference to use Interlisp CHLS instead; use UNIXUTILS ShellBrowser

[masinter]

No description provided.

[rmkaplan]

I reloaded these files into a current sysout and tried “man CONS”. It didn’t bring up the web page. Does it a new loadup?

…

On Nov 11, 2023, at 2:44 PM, Larry Masinter ***@***.***> wrote: @masinter <https://github.com/masinter> requested your review on: #1412 <#1412> Update CLHS reference to use Interlisp CHLS instead; use UNIXUTILS ShellBrowser. — Reply to this email directly, view it on GitHub <#1412 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AQSTUJLUVMK72QHYFNL4Y33YD75VZAVCNFSM6AAAAAA7HN26DGVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJQHEZTGMZQGIYTKNQ>. You are receiving this because your review was requested.

[masinter]

(1) the man command only looks in the Common Lisp HyperSpec if it is called on a symbol in the Common Lisp package. For a symbol like "CONS" that is imported into IL package it might not.
(2) The variable CLHS.ROOT.URL is set with an INITVARS, and reloading HELPSYS isn't enough.
if you SET(CLHS.ROOT.URL NOBIND) and then LOAD(HELPSYS.LCOM)

[fghalasz]

Tested on WSL, straight Ubuntu 22.04 and on MacOS. Works as expected on all. Not tested on cygwin cause can't do loadups on cygwin yet.

Couple of comments:

1. The following code in CLHS.LOOKUP
   

   could be replaced with (ShellBrowse URL)

2. You use MEDLEY-INIT-VARS to reset ShellBrowser and ShellOpener. This works, but it makes UNIXUTILS unnecessarily reliant on MEDLEYDIR and involves a lot of complexity that goes into MEDLEY-INIT-VARS.

   Why not just add a simple AROUNDEXITFN in UNIXUTILS to reset just these two variables after return to VM?

[masinter]

I changed CLHS.LOOKUP to use ShellBrowse.
I didn't make the AROUNDEXITFNS change @fghalasz suggested because it might wind up a net increase in complexity to add a new function while MEDLEYDIR and MEDLEY-INIT-VARS are still there.