Fix minor issue in ShellBrowser - when using the git path was missing the web--browse subcommand. #1420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
In ShellOpen, did you intend UNIXFILE to be used freely in the LET* ?
… On Nov 13, 2023, at 1:10 PM, Frank Halasz ***@***.***> wrote:
Noticed this issue while working on UNIXUTILS over the past week....
You can view, comment on, or merge this pull request online at:
#1420
Commit Summary
19ceac6 <19ceac6> Fix the git case in ShellBrowser. Was missing the web--browse argument.
File Changes (2 files <https://github.com/Interlisp/medley/pull/1420/files>)
M library/UNIXUTILS <https://github.com/Interlisp/medley/pull/1420/files#diff-9e36b4e8f7faade7470c7d500125160e602b3ce09ce65ce792cca917803c3e04> (17)
M library/UNIXUTILS.DFASL <https://github.com/Interlisp/medley/pull/1420/files#diff-b5a27cdd778e04c53eb33990469dc54eb23fd84d8b23b2a19926c9ce3284075a> (0)
Patch Links:
https://github.com/Interlisp/medley/pull/1420.patch
https://github.com/Interlisp/medley/pull/1420.diff
—
Reply to this email directly, view it on GitHub <#1420>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AQSTUJLVLPLIXEBAAAUKM63YEKEFRAVCNFSM6AAAAAA7JYXWC2VHI2DSMVQWIX3LMV43ASLTON2WKOZRHE4TCNBZGE2TSNQ>.
You are receiving this because you are subscribed to this thread.
|
Member
Author
Not really. But the compiler kept printing out a message that it was declaring UNIXFILE as SPECIAL. No idea why since none of the other LET* variables where so treated. So I just added the DECLARE to shut down the message, figuring if the compiler was going to declare it special then I might as well beat it to the punch. I meant to get back to figure out what was going on - but never did get around to it. Please feel free to change as you see fit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed this issue while working on UNIXUTILS over the past week....