Rmk94 fix checkeolc macro #1435
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masinter
force-pushed
the
rmk94--Fix-CHECKEOLC-macro
branch
from
4bb7280 to
d25adf9
Compare
masinter
force-pushed
the
rmk94--Fix-CHECKEOLC-macro
branch
from
b4291ed to
cdee0d6
Compare
masinter
approved these changes
Dec 9, 2023
Member
masinter
left a comment
masinter
left a comment
There was a problem hiding this comment.
there is an awful lot of complexity in end-of-line handling that I can't believe is necessary. It's being DWIMISH at the wrong level.
Some simplifying assumptions by composing pipelines when actually necessary. I haven't seen a CRLF file in years. Even if there remain some CR applications, it would remove all the extra checking and byte-length calcualations. But I understand, there's a lot of "sunk costs" in having gone down this road in the first place.
I'd be surprised if there weren't edge cases where the code doesn't work -- it's hard to think about.
But... in for a penny, in for a pound.
Approved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIxes confusion of ANY and CR EOL conventions in the macro, recompiled callers.
(I thought I had pushed this before, apparently not.)