WINDOWOBJ: Better handling of unknown image objects #1436
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: If WHEREIS says that an unknown getfn is on FOO-FIE and FOO>FOO exists, then offer FOO in the mouseconfirm. This should get all the support code (e.g. TMAX is offered instead of TMAX-NUMBER). Issue #748. Separately, if the getfn is not found when the file is opened (so the image object is encapsulated), the encapsulated imagebox fn will upgrade the image if the getfn exists when the object is redisplayed.
Contributor
Author
|
An easy addition would be a global variable that suppresses the MOUSECONFIRM, a file will load if it’s there.
We could also loosen up a bit: Assume that FOO will load for FOO-FIE just if they are sisters, not necessarily require that they also be in a FOO> subdirectory.
The general idea is that the rootfile of an application can be computed systematically from the name of the file that contains the getfn, according to WHEREIS.
In the case of Sketch, renaming just the file containing the getfn to have a hyphen prefix SKETCH- would make SKETCH available. (But I think moving all the Sketch files down a level is a separate thing to do.)
… On Nov 29, 2023, at 3:43 PM, Larry Masinter ***@***.***> wrote:
@masinter approved this pull request.
See PR #1166 <#1166> and #1167 <#1167> -- perhaps we can consolidate?
I want to set up so that HCFILES can try harder and maybe break instead of printing UNKNOWN GETFN
—
Reply to this email directly, view it on GitHub <#1436 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AQSTUJMEXIMHHE3JP7ZAZ63YG7CAZAVCNFSM6AAAAABAAHB322VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTONJWGQYDIOBQGQ>.
You are receiving this because you authored the thread.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2 changes:
If WHEREIS says that an unknown getfn is on FOO-FIE and FOO>FOO exists, then offer FOO in the mouseconfirm. This should get all the support code (e.g. TMAX is offered and loaded instead of TMAX-NUMBER). Issue If GETFN of an imageobj is not defined, try WHEREIS #748. (Sketch files would be renamed to this hyphen naming convention.)
Separately, if the getfn is still not found when the file is opened (so the image object is encapsulated), the encapsulated imagebox fn will upgrade the image when the object is redisplayed, if the getfn has been defined in the meantime. So you can TEDIT a file FOO with a Sketch image object, pass on gettiing the image object during the open, then load SKETCH explicitly. The objects will upgrade when they are redisplayed.