Skip to content

Conversation

@MattHeffron
Copy link
Contributor

Use DEFPACKAGE instead of in-package, use-package. Added (:export ...) of the 4 exported symbols.

@MattHeffron MattHeffron requested a review from Anzus December 5, 2023 20:38
@MattHeffron
Copy link
Contributor Author

The source file NEW-CLOS-BROWSER diffs as essentially a replacement due to the original having Mac EOL (CR) and this one having Unix EOL (LF). Beyond that, there are a lot of changes due to pretty-printing removing unnecessary font change characters.
The key changes are the DEFINE-FILE-INFO at the top of the file, and the writing of the IL:MAKEFILE-ENVIRONMENT property at lines 331 (old) - 276 (new).

Copy link
Member

@masinter masinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to see some work on the Common Lisp implementation.
d

@rmkaplan rmkaplan merged commit 2a9076b into master Dec 10, 2023
@MattHeffron MattHeffron deleted the NEW-CLOS-BROWSER_fix_exports branch January 11, 2024 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants