mth7--rmk5--GITFNS-defaults-to-all-PRs-including-drafts #1692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nvert it to a list of PLISTs.
Added double-quotes around all places where a branch name is given to GIT-COMMAND. This seems to fix issue #1691
Contributor
|
I have some other changes to the prc menu interface in GITFNS, stacked up behind the current switch to JSON. So we will have to resynchronize.
… On May 2, 2024, at 12:18 AM, Matt Heffron ***@***.***> wrote:
Change parsing of JSON returned from gh, to lisp alist vs. plist.
Added double-quotes around all (?) places where a branch name is given to GIT-COMMAND. This seems to fix issue #1691 <#1691>
You can view, comment on, or merge this pull request online at:
#1692
Commit Summary
db2617a <db2617a> Default prc menu shows all open PRs, draft and nondraft
c3b77a1 <c3b77a1> Update GIT-PULL-REQUESTS to get the pull requests info in JSON and convert it to a list of PLISTs.
177a389 <177a389> Change parsing of JSON returned from gh to lisp alist vs. plist.
File Changes (3 files <https://github.com/Interlisp/medley/pull/1692/files>)
M lispusers/GITFNS <https://github.com/Interlisp/medley/pull/1692/files#diff-4d95b45b781296b2043184a8dd06664d3e6cbc86e58e8f75c75adeea28d847c4> (334)
M lispusers/GITFNS.LCOM <https://github.com/Interlisp/medley/pull/1692/files#diff-100a78f9d369ac895cb9f1587123c4ddf9a5e944c13b3c65a72db6145b9297ed> (0)
M lispusers/GITFNS.TEDIT <https://github.com/Interlisp/medley/pull/1692/files#diff-07dc152df3305a5cf6d4e9ca3caa18268b741f17a70dae1a2c92386f81213949> (0)
Patch Links:
https://github.com/Interlisp/medley/pull/1692.patch
https://github.com/Interlisp/medley/pull/1692.diff
—
Reply to this email directly, view it on GitHub <#1692>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AQSTUJI7FVFOZY6HAER5UOLZAHSDXAVCNFSM6AAAAABHDFF4H6VHI2DSMVQWIX3LMV43ASLTON2WKOZSGI3TINZZGY4TINA>.
You are receiving this because you are subscribed to this thread.
|
Contributor
Author
|
I'll separate out the JSON parsing bits from the branch name quoting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change parsing of JSON returned from gh, to lisp alist vs. plist.
Added double-quotes around all (?) places where a branch name is given to GIT-COMMAND. This seems to fix issue #1691