Format implementation functions set a known variable *BYTECOUNTER* #402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The generic functions deal with updating the application variable. \INCHAR eliminated in favor of \INCCODE.EOLC to make clear what it does. OPENSTRINGSTREAM streams have their own format, and the string is always fattened. READBITMAP doesn't mix character and byte reading
Member
|
it used to be we'd name special variables with \ or in the SI package or... |
Member
|
I'm looking at `grep -ri '\inchar> .' to look for things you might have missed. There are some comments in JAPANESE. CLtL2 has of course older files stashed away. It would mitigate the risk to leave behind \INCHAR ... |
This creates a file device that is not used anywhere. The function OPENSTRINGSTREAM provides the functionality that this file device suggests that it would provide, but that functionality seems suspect at best. The function is left in the system for now, probably should be deleted at some point in the future so we don't try to maintain it if we trip over it.
masinter
requested changes
Aug 10, 2021
Member
masinter
left a comment
masinter
left a comment
There was a problem hiding this comment.
typing
(DIRECTORY ?= and CR in older sysouts shows the DIRECTORY argument list.
In this update, it gives an invalid argument NIL
Contributor
in a newly built sysout, but not the one that's checked in as part of the branch. |
Contributor
Author
|
This is in TTYIN, where it seems to be doing its own buffer management. Ugh.
… On Aug 10, 2021, at 9:39 AM, Nick Briggs ***@***.***> wrote:
typing
(DIRECTORY ?= and CR in older sysouts shows the DIRECTORY argument list.
In this update, it gives an invalid argument NIL
in a newly built sysout, but not the one that's checked in as part of the branch.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#402 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AQSTUJIGGTCGKX54W3FP5RTT4FI5NANCNFSM5BY5WUFA>.
|
Member
Why does this have anything to do with TTYIN? |
Contributor
Author
|
Who knows? The problem seems to be a difference in what appears to be a private,clever simulation of the input buffer, just in the case of ?= as far as I can tell. It does use NODIRCORE to load the buffer into something that it can read, but the error happens before then.
Still looking.
… On Aug 10, 2021, at 2:57 PM, Larry Masinter ***@***.***> wrote:
The generic functions deal with updating the application variable.
\INCHAR eliminated in favor of \INCCODE.EOLC to make clear what it does.
OPENSTRINGSTREAM streams have their own format, and the string is always fattened.
READBITMAP doesn't mix character and byte reading (some other functions still do)
Why does this have anything to do with TTYIN?
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub <#402 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AQSTUJIMSISSDF2WTYS5K63T4GOEPANCNFSM5BY5WUFA>.
|
but still doesn't solve the (DIRECTORY ?= problem #402
Added \BACKCCODE.EOLC that backs up over EOL encoding bytes, simplifies \RSTRING2. \XCCSBACKCCODE returns T/NIL according to whether it succeeded. \XCCSOUTCHAR uses IPLUS16 for CHARPOSITION COPYCHARS makes no assumptions about EOL encoding But still no solution for #402
The bug showed up in TTYIN, but it was actually a bad edit in the generic backccode. TTYIN.LCOM is just a recompile--that had never been done with various new declarations.
masinter
approved these changes
Aug 14, 2021
Member
masinter
left a comment
masinter
left a comment
There was a problem hiding this comment.
I wish you wouldn't change CONDs to CL:WHEN and CL:UNLESS in old code that isn't otherwise changing -- it makes the changes harder to review.
Contributor
Author
|
The parameter was in the wrong argument position, it was a noop.
… On Aug 14, 2021, at 10:23 AM, Larry Masinter ***@***.***> wrote:
@masinter approved this pull request.
I wish you wouldn't change CONDs to CL:WHEN and CL:UNLESS in old code that isn't otherwise changing -- it makes the changes harder to review.
In sources/TTYIN <#402 (comment)>:
> @@ -5600,12 +5600,10 @@ Copyright (c) 1982-1988, 1990-1991, 2021 by Venue & Xerox Corporation.
(TTYIN.SCRATCHFILE
[LAMBDA NIL
- (DECLARE (GLOBALVARS TTYINEDIT.SCRATCH)) (* lmm "14-Nov-86 17:05")
- [COND
- ([OR (NOT TTYINEDIT.SCRATCH)
- (NOT (OPENP TTYINEDIT.SCRATCH 'BOTH]
- (SETQ TTYINEDIT.SCRATCH (OPENSTREAM '{NODIRCORE} 'BOTH 'OLD/NEW NIL
- (CONSTANT (LIST (LIST 'ENDOFSTREAMOP (FUNCTION \TTYIN.RPEOF]
+ (DECLARE (GLOBALVARS TTYINEDIT.SCRATCH)) (* ; "Edited 13-Aug-2021 11:07 by rmk:")
+ (CL:UNLESS (AND TTYINEDIT.SCRATCH (OPENP TTYINEDIT.SCRATCH 'BOTH))
+ [SETQ TTYINEDIT.SCRATCH (OPENSTREAM '{NODIRCORE} 'BOTH 'OLD/NEW
+ (CONSTANT (LIST (LIST 'ENDOFSTREAMOP (FUNCTION \TTYIN.RPEOF])
I can't fathom how this code had anything that needed to change with the recent changes to how character/binary codes were default/special-cased.
I can't see what you changed there. And "COND" was more appropriate than "CL:UNLESS" for just syntactic change.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub <#402 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AQSTUJOUXSIZ6EAJTG63VELT42RAZANCNFSM5BY5WUFA>.
|
masinter
pushed a commit
that referenced
this pull request
Aug 16, 2021
) * Format implementation functions set a known variable *BYTECOUNTER* The generic functions deal with updating the application variable. \INCHAR eliminated in favor of \INCCODE.EOLC to make clear what it does. OPENSTRINGSTREAM streams have their own format, and the string is always fattened. READBITMAP doesn't mix character and byte reading * AOFD: Don't execute \STRINGSTREAM.INIT This creates a file device that is not used anywhere. The function OPENSTRINGSTREAM provides the functionality that this file device suggests that it would provide, but that functionality seems suspect at best. The function is left in the system for now, probably should be deleted at some point in the future so we don't try to maintain it if we trip over it. * TTYIN: Fix an ancient coding error but still doesn't solve the (DIRECTORY ?= problem #402 * LLREAD, FILEIO, XCCS: Improve charcode backing, copychars Added \BACKCCODE.EOLC that backs up over EOL encoding bytes, simplifies \RSTRING2. \XCCSBACKCCODE returns T/NIL according to whether it succeeded. \XCCSOUTCHAR uses IPLUS16 for CHARPOSITION COPYCHARS makes no assumptions about EOL encoding But still no solution for #402 * LLREAD, TTYIN.LCOM fix #402 The bug showed up in TTYIN, but it was actually a bad edit in the generic backccode. TTYIN.LCOM is just a recompile--that had never been done with various new declarations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generic functions deal with updating the application variable.
\INCHAR eliminated in favor of \INCCODE.EOLC to make clear what it does.
OPENSTRINGSTREAM streams have their own format, and the string is always fattened.
READBITMAP doesn't mix character and byte reading (some other functions still do)