Skip to content

Conversation

@rmkaplan
Copy link
Contributor

A few more minor updates

Turns out that FILEDATE of a compiled file returns the creation date of the source, not the compiled file.  To get the proper date for both source and compiled files, you have to first call it with CFLG=T, if that is NIL, try with CFLG=NIL, if that's NIL it isn't a Medley file, use the creation date.

Would be more intuititive with different semantics:  (FILEDATE   xx NIL) should give you the date of this file whether compiled or not, (FILEDATE xx T) should give you the date of the source file, if it happens to be a compiled file.  I.e, CFLG → SFLG
Copy link
Contributor

@nbriggs nbriggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if it was the way it was so that one would notice that the compiled file date was the same as (different from) the source file date as a hint that they were (were not) a matched pair?

@rmkaplan
Copy link
Contributor Author

I'm wondering if it was the way it was so that one would notice that the compiled file date was the same as (different from) the source file date as a hint that they were (were not) a matched pair?

That could have been the rationale. But then, that would have been only one of the reasonable use cases. Maybe there should be (have been) a separate entry that more clearly lets you ask for the kind of date you want--date of this file, or date of the source file if this is a compiled file ((→ NIL if this is not a compiled file). But I have patched around it for now.

Copy link
Member

@masinter masinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rmkaplan rmkaplan merged commit 869b3a2 into master Nov 27, 2021
@rmkaplan rmkaplan deleted the rmk2 branch December 2, 2021 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants