Rmk3 #587
Merged
Rmk3 #587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needs to be done for most CL-function containing files.
masinter
reviewed
Nov 28, 2021
| (FILECREATED " 3-Apr-91 15:11:53" |{PELE:MV:ENVOS}<LISPCORE>SOURCES>CLSTREAMS.;4| 54013 | ||
|
|
||
| |changes| |to:| (FUNCTIONS CL:WITH-INPUT-FROM-STRING) | ||
| (FILECREATED "27-Nov-2021 13:30:46" |
Member
There was a problem hiding this comment.
can't tell what changed in CLSTREAMS (besides re-pretty-printing with a different fontset.
Contributor
Author
|
The filemap. Now includes FUNCTIONS.
(LOAD x ‘PROP)
(MAKEFILE x ’NEW)
Should be done eventually to all the files containing FUNCTIONS
… On Nov 27, 2021, at 7:49 PM, Larry Masinter ***@***.***> wrote:
@masinter commented on this pull request.
In sources/CLSTREAMS <#587 (comment)>:
>
- |changes| |to:| (FUNCTIONS CL:WITH-INPUT-FROM-STRING)
+(FILECREATED "27-Nov-2021 13:30:46"
can't tell what changed in CLSTREAMS (besides re-pretty-printing with a different fontset.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#587 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AQSTUJKZ6ULO4IJMZIU5OR3UOGREPANCNFSM5I4ZPBXQ>.
|
Member
|
Isn't there a function that rewrites the FILEMAP without re-pretty-printing all the files? I'm worried about e.g., some PRETTYPRINT macro being buggy and winding up with different code than intended. |
Contributor
Author
|
There is function UPDATEFILEMAP. Is that what you are thinking of?
Dated bvm 1986, with a comment
(* ;;; "Writes new FILEMAP on file currently open as STREAM. If we return T, the stream has been closed.
This has little hope of working any more.”)
I don’t know of a function that creates a new file map, other than when (re)printing.
… On Nov 28, 2021, at 9:54 AM, Larry Masinter ***@***.***> wrote:
Isn't there a function that rewrites the FILEMAP without re-pretty-printing all the files?
I'm worried about e.g., some PRETTYPRINT macro being buggy and winding up with different code than intended.
I'm not sure all of the Lisp sources will survive the translation.
If a function has an EXPR definition (not compiled) and you LOAD(... PROP) with a new definition, won't MAKEFILE(... NEW) get the old definition instead of the new?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#587 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AQSTUJI3CLQGDMOLDUQBXTDUOJUFZANCNFSM5I4ZPBXQ>.
|
masinter
approved these changes
Nov 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved Tedit menu scrolling, updated filemaps