Rmk62 old tedit formats and nits #851
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TEDIT-OFD also traps non-stream TEXT arguments that should no longer propagate
Also, changed the name from Function Keys to Tedit Keys, made the shrunk window open on left-click
Contributor
|
Loaded up a new sysout on this branch, tried to TEDIT |
masinter
reviewed
Jul 20, 2022
Member
masinter
left a comment
masinter
left a comment
There was a problem hiding this comment.
in TEDIT-FILE's \TEDIT.CONVERT.FOREIGN.FORMAT doesn't the call to (OPENTEXTSTREAM "") now treat "" as a pathname?
Contributor
Author
|
I think there is something else going on, a confusion between the original file stream, a “textstream”, and the textofd. The textformattedp1 function only operates on file streams, not on text streams.
… On Jul 20, 2022, at 10:50 AM, Larry Masinter ***@***.***> wrote:
@masinter commented on this pull request.
in TEDIT-FILE's \TEDIT.CONVERT.FOREIGN.FORMAT doesn't the call to (OPENTEXTSTREAM "") now treat "" as a pathname?
—
Reply to this email directly, view it on GitHub <#851 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AQSTUJK7MLTNXZRYT76VTTDVVA37ZANCNFSM54EOQAVA>.
You are receiving this because you authored the thread.
|
Contributor
Author
|
Try it again
… On Jul 20, 2022, at 10:53 AM, Ron Kaplan ***@***.***> wrote:
I think there is something else going on, a confusion between the original file stream, a “textstream”, and the textofd. The textformattedp1 function only operates on file streams, not on text streams.
> On Jul 20, 2022, at 10:50 AM, Larry Masinter ***@***.*** ***@***.***>> wrote:
>
>
> @masinter commented on this pull request.
>
> in TEDIT-FILE's \TEDIT.CONVERT.FOREIGN.FORMAT doesn't the call to (OPENTEXTSTREAM "") now treat "" as a pathname?
>
> —
> Reply to this email directly, view it on GitHub <#851 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AQSTUJK7MLTNXZRYT76VTTDVVA37ZANCNFSM54EOQAVA>.
> You are receiving this because you authored the thread.
>
|
Contributor
Author
|
New commits address Larry's earlier comment about (OPENTEXTSTREAM ""). Unrelated to the other problem in loading image objects. |
Member
|
(HCFILES) runs on all TEDIT / SKETCH files in Medley repo. |
masinter
approved these changes
Jul 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly reading old-format TEDIT files. A few other minor adjustments