Remove bignum test from \INSERTTREE -- was just a debugging aid #863
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I think Nick suggested keeping the check but testing against MAX.FIXP instead of type BIGNUM
… On Jul 26, 2022, at 10:42 AM, Larry Masinter ***@***.***> wrote:
@masinter <https://github.com/masinter> requested your review on: #863 <#863> Remove bignum test from \INSERTTREE -- was just a debugging aid.
—
Reply to this email directly, view it on GitHub <#863 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AQSTUJOPHG4C3RRDXTUDGETVWAPPNANCNFSM54WYZWMQ>.
You are receiving this because your review was requested.
|
Contributor
|
We should probably not merge debugging hacks into master. If it's debugging code that others should try, it's easy enough to push a branch to github so they can get it... no PR is necessary, just announce the branch name. Since |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #859
This change was put in by me as a hack. \PUTBASEFIXP already checks against bignums. It is only because it was under an UNINTERRUPTABLY that it called RAID rather than signalling a Lisp error.
The code here could be improved but putting it back seems like the prudent approach-- something else is going wrong well before we get here.