Skip to content

Conversation

@masinter
Copy link
Member

@masinter masinter commented Aug 4, 2022

No description provided.

Copy link
Contributor

@rmkaplan rmkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be OK, but GITFNS is showing me some of the changed files but with no actual changes (e.g. DINFO). Is GITFNS missing something, or are some of these have character differences that git picks up but that GITFNS properly realizes as having no significance?

@masinter
Copy link
Member Author

Just to make sure there wasn't a redefinition of the TABLEBROWSER and TABLEITEM records, I went ahead and did the UNSAVEFNS to mark some functions as changed so as to recompile them.
It would be good if PRC could make sure compiled files match the files they were supposedly compiled on.

@rmkaplan
Copy link
Contributor

rmkaplan commented Aug 11, 2022 via email

@masinter masinter requested a review from rmkaplan August 11, 2022 19:27
Copy link
Contributor

@rmkaplan rmkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is OK. prc shows all of these key changes, plus some other differences that maybe have to do with commit that are ahead or behind.

But I think this looks good

@masinter masinter merged commit 431d80f into master Aug 12, 2022
@masinter masinter deleted the duplicate-tablebrowserdecls branch August 12, 2022 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants