Rmk66: 2 little glitches, plus GITFNS prc dealing better with forking #887
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even though field was never referenced
Reconciled with Larry's previous commit
nbriggs
reviewed
Aug 12, 2022
Contributor
nbriggs
left a comment
nbriggs
left a comment
There was a problem hiding this comment.
In the VT100SAVE record, the CHARSET field never seems to be referenced, so does it need to be there? If it's referenced by some other code outside of VTCHAT then presumably those should be updated in this revision to use the new name.
Contributor
Author
|
I did a scan and didn’t see it, but maybe there was a rationale. So, convervatively, I at least left the cell.
… On Aug 11, 2022, at 7:07 PM, Nick Briggs ***@***.***> wrote:
@nbriggs commented on this pull request.
In the VT100SAVE record, the CHARSET field never seems to be referenced, so does it need to be there? If it's referenced by some other code outside of VTCHAT then presumably those should be updated in this revision to use the new name.
—
Reply to this email directly, view it on GitHub <#887 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AQSTUJO3CYT5VYX4BBO77W3VYWWXZANCNFSM56KEIGPA>.
You are receiving this because you authored the thread.
|
masinter
reviewed
Aug 13, 2022
|
|
||
| (RECORD VT100SAVE (CURSORPOS CHARATTR CHARSET)) | ||
| (RECORD VT100SAVE (CURSORPOS CHARATTR VTSCHARSET)) | ||
|
|
Member
There was a problem hiding this comment.
the CHARSET/VTSCHARSET field doesn't seem to be used. In ALLCONTENT.
masinter
approved these changes
Aug 13, 2022
Member
masinter
left a comment
masinter
left a comment
There was a problem hiding this comment.
After reallizing that I'd wandered into the second half of the PRC differences, LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.