Skip to content

fix triton fp8 all_reduce group - #4702

Merged
lvhan028 merged 1 commit into
InternLM:mainfrom
grimoire:fix-fallback-fp8
Jun 25, 2026
Merged

fix triton fp8 all_reduce group#4702
lvhan028 merged 1 commit into
InternLM:mainfrom
grimoire:fix-fallback-fp8

Conversation

@grimoire

Copy link
Copy Markdown
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily receiving feedbacks. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  3. If the modification has a dependency on downstream projects of a newer version, this PR should be tested with all supported versions of downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

Copilot AI review requested due to automatic review settings June 24, 2026 04:08

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes tensor-parallel communication behavior for the Triton FP8 blocked linear backend by ensuring the correct distributed process group is used during all_reduce.

Changes:

  • Pass group=group to dist.all_reduce(...) in TritonLinearBlockedF8Impl.forward, aligning it with the existing reduce_scatter_by_tp_sizes(..., group=group) path and the DeepGemm implementation.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@lvhan028
lvhan028 merged commit 9f4f842 into InternLM:main Jun 25, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants