fix: gzip torch profiler traces by default - #4747
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reduces the storage footprint of LMDeploy’s PyTorch profiler Chrome trace exports by switching the default trace output to gzip-compressed JSON, while keeping an environment-variable opt-out for plain JSON.
Changes:
- Add
LMDEPLOY_PROFILE_USE_GZIP(defaultTrue) to control whether profiler traces are written as.json.gzor.json. - Update the profiler dump path logic to emit
.json.gzby default. - Document the new setting in both English and Chinese profiling guides.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lmdeploy/pytorch/envs.py | Introduces torch_profile_use_gzip env-backed flag (LMDEPLOY_PROFILE_USE_GZIP, default on). |
| lmdeploy/pytorch/engine/model_agent/profiler.py | Switches trace output suffix to .json.gz when gzip is enabled. |
| docs/zh_cn/advance/pytorch_profiling.md | Documents default gzip behavior and the opt-out env var. |
| docs/en/advance/pytorch_profiling.md | Documents default gzip behavior and the opt-out env var. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
grimoire
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
PyTorch profiler traces can grow large, while LMDeploy currently exports them as plain JSON. vLLM enables gzip by default for the same
export_chrome_traceflow to reduce storage use.Changes
.json.gzby default.LMDEPLOY_PROFILE_USE_GZIP=0.Validation
Assistance
Assisted with Codex + GPT-5.5 xHigh Fast, reviewed manually