ci: pin jlumbroso/free-disk-space to a full commit SHA - #4748
Merged
Conversation
This third-party action is referenced by the mutable @main tag in 12 workflows (15 occurrences), including the DockerHub-push (docker.yml, docker_nightly.yml) and PyPI-publish (pypi.yml) jobs. Pin every occurrence to the current main commit SHA (tag kept in a trailing comment) so a moved tag can't run unreviewed code alongside the registry / package-index credentials. Behaviour unchanged; per GitHub's guidance to pin actions to a full-length commit SHA. Signed-off-by: Kobi Hikri <kobi.hikri@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens GitHub Actions usage by replacing the moving ref jlumbroso/free-disk-space@main with a full commit SHA across multiple workflows, reducing supply-chain risk in jobs that may have access to publishing credentials.
Changes:
- Pin
jlumbroso/free-disk-spacefrom@mainto@54081f138730dfa15788a46383842cd2f914a1bein the touched workflows. - Keep the previous ref (
main) as a trailing comment for readability/auditing.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/test_docker.yml | Pins jlumbroso/free-disk-space to a full SHA in multiple jobs/steps. |
| .github/workflows/pypi.yml | Pins jlumbroso/free-disk-space to a full SHA in the PyPI publishing workflow. |
| .github/workflows/mllm_api_eval.yml | Pins jlumbroso/free-disk-space to a full SHA. |
| .github/workflows/linux_x64_gpu.yml | Pins jlumbroso/free-disk-space to a full SHA. |
| .github/workflows/evaluate.yml | Pins jlumbroso/free-disk-space to a full SHA. |
| .github/workflows/docker.yml | Pins jlumbroso/free-disk-space to a full SHA in Docker publishing workflows. |
| .github/workflows/docker_nightly.yml | Pins jlumbroso/free-disk-space to a full SHA. |
| .github/workflows/daily_ete_test.yml | Pins jlumbroso/free-disk-space to a full SHA. |
| .github/workflows/daily_ete_test_5080.yml | Pins jlumbroso/free-disk-space to a full SHA. |
| .github/workflows/daily_ete_test_3090.yml | Pins jlumbroso/free-disk-space to a full SHA. |
| .github/workflows/benchmark.yml | Pins jlumbroso/free-disk-space to a full SHA. |
| .github/workflows/api_eval.yml | Pins jlumbroso/free-disk-space to a full SHA. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| steps: | ||
| - name: Free disk space | ||
| uses: jlumbroso/free-disk-space@main | ||
| uses: jlumbroso/free-disk-space@54081f138730dfa15788a46383842cd2f914a1be # main |
Collaborator
|
@windreamer Any ideas on how to fix the [test_jetson_docker_image] (https://github.com/InternLM/lmdeploy/actions/runs/29265427834/job/87052526213?pr=4748#logs) failure? |
Collaborator
|
overall LGTM. |
lvhan028
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Pin
jlumbroso/free-disk-space@main→54081f1…everywhere it's used (15 occurrences across 12workflows), keeping the tag in a trailing comment.
Why
@mainis a moving reference — whatever it points to at run time runs in the job. Several of these jobshold publishing credentials:
docker.yml/docker_nightly.yml— DockerHub login + pushpypi.yml—twine uploadwithpypi_passwordIf the action's
mainwere moved (compromise or an accidental change), the new code would run in a jobholding registry / PyPI credentials — the class of issue behind the 2025
tj-actions/changed-filesincident, here with the ability to tamper with published images and wheels.
Scope / safety
main.Per GitHub's guidance to pin actions to a full-length commit SHA.
AI-assisted; I verified the workflows, the credential exposure, and the pinned SHA myself.