update turbomind builder image - #4752
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the manywheel/turbomind builder workflow to use a manylinux_2_28-based image and aligns builder/wheel build scripts with the new tagging and Dockerfile naming, while also removing a hard dependency on the GNU gold linker from the CMake build.
Changes:
- Remove forced
ld.goldusage fromCMakeLists.txtso builds can use the default linker. - Add a
manylinux_2_28builder Dockerfile and update builder image tagging to include the manylinux version. - Adjust build scripts to default toward manylinux_2_28 (builder + wheel builds).
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| CMakeLists.txt | Removes the enforced gold-linker requirement/flags. |
| builder/manywheel/Dockerfile_2_28 | Adds a manylinux_2_28-based builder image definition (CUDA + conda envs). |
| builder/manywheel/build_lmdeploy_builder.sh | Updates builder image tag/Dockerfile selection for manylinux-versioned builds. |
| builder/manywheel/build_all_wheel.sh | Switches default platform to manylinux_2_28 and updates wheel build tag naming. |
| builder/manywheel/build_all_lmdeploy_builders.sh | Makes manylinux version and CUDA version configurable via env defaults. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
lvhan028
reviewed
Jul 16, 2026
lvhan028
reviewed
Jul 16, 2026
lvhan028
reviewed
Jul 16, 2026
lvhan028
reviewed
Jul 16, 2026
Collaborator
|
Please fix the linting error |
lvhan028
reviewed
Jul 17, 2026
lvhan028
reviewed
Jul 17, 2026
lvhan028
reviewed
Jul 17, 2026
Comment on lines
+110
to
+126
| function install_130 { | ||
| echo "Installing CUDA 13.0 and NCCL 2.30.3" | ||
| rm -rf /usr/local/cuda-13.0 /usr/local/cuda | ||
| # install CUDA 13.0.3 in the same container | ||
| wget -q https://developer.download.nvidia.com/compute/cuda/13.0.3/local_installers/cuda_13.0.3_580.126.20_linux.run | ||
| chmod +x cuda_13.0.3_580.126.20_linux.run | ||
| ./cuda_13.0.3_580.126.20_linux.run --toolkit --silent | ||
| rm -f cuda_13.0.3_580.126.20_linux.run | ||
| rm -f /usr/local/cuda && ln -s /usr/local/cuda-13.0 /usr/local/cuda | ||
|
|
||
| # NCCL license: https://docs.nvidia.com/deeplearning/nccl/#licenses | ||
| mkdir tmp_nccl && cd tmp_nccl | ||
| wget -q https://developer.download.nvidia.com/compute/redist/nccl/v2.30.3/nccl_2.30.3-1+cuda13.2_x86_64.txz | ||
| tar xf nccl_2.30.3-1+cuda13.2_x86_64.txz | ||
| cp -a nccl_2.30.3-1+cuda13.2_x86_64/include/* /usr/local/cuda/include/ | ||
| cp -a nccl_2.30.3-1+cuda13.2_x86_64/lib/* /usr/local/cuda/lib64/ | ||
| cd .. |
Comment on lines
25
to
29
| docker_build_args=( | ||
| -t "${DOCKER_IMAGE}" | ||
| --target "${TARGET}" | ||
| -f "${TOPDIR}/manywheel/Dockerfile${DOCKERFILE_SUFFIX}" | ||
| -f "${TOPDIR}/manywheel/Dockerfile_${MANY_LINUX_VERSION}" | ||
| ) |
lvhan028
approved these changes
Jul 17, 2026
|
|
||
| # NCCL license: https://docs.nvidia.com/deeplearning/nccl/#licenses | ||
| mkdir tmp_nccl && cd tmp_nccl | ||
| wget -q https://developer.nvidia.com/w/compute/redist/nccl/v2.28.9/nccl_2.28.9-1+cuda13.0_x86_64.txz |
| ## KV Cache Manager | ||
|
|
||
| The [KV cache manager](https://github.com/InternLM/lmdeploy/blob/main/src/turbomind/models/llama/SequenceManager.h) of TurboMind is a memory-pool-liked object that also implements LRU policy so that it can be viewed as a form of __cache of KV caches__. It works in the following way | ||
| The KV cache manager of TurboMind is a memory-pool-liked object that also implements LRU policy so that it can be viewed as a form of __cache of KV caches__. It works in the following way |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily receiving feedbacks. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Please describe the motivation of this PR and the goal you want to achieve through this PR.
Modification
Please briefly describe what modification is made in this PR.
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist