Skip to content

Bisect #739 m_Header.pcs #759

@xsscx

Description

@xsscx

Maintainer Summary

2026-03-29 05:57:59 UTC

Bisect

Good: f49ad79
Bad: 306139d

Good Breadcrumb f49ad79

[2026-03-29 05:55:15 UTC] ~/f49ad79/iccDEV/Testing/hybrid ((HEAD detached at f49ad79))$ ASAN_OPTIONS=print_scariness=1:halt_on_error=0:abort_on_error=0:print_full_stacktrace=1:detect_leaks=0 iccApplySearch Results/cmykGraysRef.txt 0 1 ICC/Spec380_10_730-D50_2deg.icc 3 ICC/Lab_float-D50_2deg.icc 3 ICC/CMYK_Hybrid_Profile.icc 10003 -INIT 3 ICC/Lab_float-D50_2deg.icc 1 ICC/Lab_float-D93_2deg-MAT.icc 1 ICC/Lab_float-F11_2deg-MAT.icc 1 ICC/Lab_float-IllumA_2deg-MAT.icc 1
'CMYK'  ; Data Format
icEncodeValue   ; Encoding

;Source Data Format: "nc0024"
;Source Data Encoding: icEncodeFloat
;Source data is after semicolon

;Profiles applied
; ICC/Spec380_10_730-D50_2deg.icc
; ICC/Lab_float-D50_2deg.icc
; ICC/CMYK_Hybrid_Profile.icc

    0.4927    0.3933    0.3940    0.0132        ;    0.0880    0.1146    0.1470    0.1989    0.2517    0.2704    0.2793    0.2806    0.2768    0.2676    0.2658    0.2882    0.3229    0.3347    0.3151    0.2844    0.2505    0.2149    0.1871    0.1789    0.2001    0.2416    0.2760    0.2944    0.3042    0.3117    0.3214    0.3338    0.3419    0.3414    0.3351    0.3250    0.3189    0.3249    0.3396    0.3396
    0.0015    0.0012    0.0019    0.4988        ;    0.1022    0.1293    0.1642    0.2352    0.3135    0.3394    0.3446    0.3387    0.3306    0.3215    0.3123    0.3085    0.3097    0.3116    0.3111    0.3093    0.3064    0.3006    0.2947    0.2938    0.2996    0.3036    0.3019    0.3000    0.3007    0.3035    0.3072    0.3109    0.3129    0.3129    0.3116    0.3099    0.3096    0.3116    0.3154    0.3154

Bad Breadcrumb 306139d

[2026-03-29 05:55:01 UTC] ~/306139d/iccDEV/Testing/hybrid ((HEAD detached at 306139d))$ ASAN_OPTIONS=print_scariness=1:halt_on_error=0:abort_on_error=0:print_full_stacktrace=1:detect_leaks=0 iccApplySearch Results/cmykGraysRef.txt 0 1 ICC/Spec380_10_730-D50_2deg.icc 3 ICC/Lab_float-D50_2deg.icc 3 ICC/CMYK_Hybrid_Profile.icc 10003 -INIT 3 ICC/Lab_float-D50_2deg.icc 1 ICC/Lab_float-D93_2deg-MAT.icc 1 ICC/Lab_float-F11_2deg-MAT.icc 1 ICC/Lab_float-IllumA_2deg-MAT.icc 1
Error 3 - Unable to begin profile application - Possibly invalid or incompatible profiles

Build

git clone https://github.com/InternationalColorConsortium/iccDEV.git
cd iccDEV
git checkout {Breadcrumb}
cd Build
export CXX=clang++ && export CXXFLAGS="-fsanitize=address,undefined -fno-omit-frame-pointer -g -O1 -fprofile-arcs -ftest-coverage" && export LDFLAGS="-fsanitize=address,undefined -fprofile-arcs" && cmake Cmake -DCMAKE_BUILD_TYPE=Debug -DENABLE_ASAN=ON -DENABLE_UBSAN=ON -DENABLE_COVERAGE=ON -DENABLE_TOOLS=ON
make -j32
        cd ../Testing/
        echo "=== Updating PATH ==="
         for d in ../Build/Tools/*; do
          [ -d "$d" ] && export PATH="$(realpath "$d"):$PATH"
         done

diff

  // CFL-045: Guard against null PCS causing vptr corruption in copy (CWE-843)
- if (pProfile && (icUInt32Number)pProfile->m_Header.pcs == 0) {
+ if (pProfile && (icUInt32Number)pProfile->m_Header.pcs == 0 && (icUInt32Number)pProfile->m_Header.spectralPCS == 0) {

Metadata

Metadata

Assignees

Labels

BisectMaintainer indicates BisectMLMaintainer indicates topic related to Machine LearningTriagedMaintainer indicates triaged status and ready for developer handoff

Type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions