Skip to content

Fix: CI Scripts#756

Merged
xsscx merged 2 commits intomasterfrom
fix-ci-scripts
Mar 29, 2026
Merged

Fix: CI Scripts#756
xsscx merged 2 commits intomasterfrom
fix-ci-scripts

Conversation

@xsscx
Copy link
Copy Markdown
Member

@xsscx xsscx commented Mar 29, 2026

Pull Request Checklist

#755

  • Have you followed the guidelines in Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you built your Pull Request locally with the Build Instructions?
  • Have you added or updated relevant tests?
  • Have you added or updated relevant docs?

@xsscx xsscx self-assigned this Mar 29, 2026
@xsscx xsscx added the PR Pull Request label Mar 29, 2026
@xsscx xsscx requested a review from dwtza as a code owner March 29, 2026 03:21
@xsscx xsscx added the Merge Ready Maintainer indicates Merge Ready label Mar 29, 2026
@xsscx xsscx removed the request for review from dwtza March 29, 2026 03:21
@xsscx xsscx requested a review from ChrisCoxArt March 29, 2026 03:21
@xsscx xsscx linked an issue Mar 29, 2026 that may be closed by this pull request
Bisect #708 Testing/ #755
Closed
@xsscx xsscx removed a link to an issue Mar 29, 2026
Bisect #708 Testing/ #755
Closed
@xsscx xsscx linked an issue Mar 29, 2026 that may be closed by this pull request
Bisect #739 m_Header.pcs #759
Closed
@xsscx xsscx added Pending Merge Maintainer indicates Merge Pending and Requests No Further Changes and removed Merge Ready Maintainer indicates Merge Ready pending labels Mar 29, 2026
@xsscx xsscx added Test Status Maintainer indicates TEST Status CI and removed Pending Merge Maintainer indicates Merge Pending and Requests No Further Changes pending labels Mar 29, 2026
fix: CI script hardening and comprehensive tool tests
9b60294 
- Fix BuildAndTest.sh binary name case (lowercase matches cmake output)
- Fix BuildAndTest.bat config path separators (forward slash → backslash)
- Harden BuildAndTest.sh: set -eu, mkdir -p ICC Results config
- POSIX-safe arithmetic: ((passed++)) → passed=$((passed + 1))
- Add ci-iccdev-tool-tests.yml: 17-phase smoke test for all 15 iccDEV tools
- Add ci-buildandtest-ab.yml: A/B validation for BuildAndTest.sh
- Windows BuildAndTest.bat: continue-on-error for pre-existing Invalid Profile failures
- Remove placeholder .gitkeep files from ICC/ and Results/ directories

Bisect: BAD=f0030ed GOOD=9f53e42 (PR #708 introduced uppercase binary names)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
fix(ci): continue-on-error for Create Profiles step
102b9c6 
Profile creation bat scripts fail when intermediate TIFF results
and overprint ICC profiles are not yet generated, causing exit code 1
to abort the entire job.

Ref: https://github.com/InternationalColorConsortium/iccDEV/actions/runs/23705698882/job/69057155130

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@xsscx xsscx removed the Test Status Maintainer indicates TEST Status label Mar 29, 2026
@xsscx xsscx added Pending Merge Maintainer indicates Merge Pending and Requests No Further Changes and removed CI pending labels Mar 29, 2026
@xsscx xsscx merged commit fed8595 into master Mar 29, 2026
1 check passed
@xsscx xsscx removed the Pending Merge Maintainer indicates Merge Pending and Requests No Further Changes label Mar 29, 2026
@xsscx xsscx linked an issue Mar 29, 2026 that may be closed by this pull request
Bisect #708 Testing/ #755
Closed
xsscx pushed a commit that referenced this pull request Mar 29, 2026
demo-rit: BeyondRGB integration + rebase onto master v2.3.1.6
1522240 
Squashed 23 commits from the demo-rit branch, rebased onto latest master
(v2.3.1.6, commit fed8595) incorporating all upstream bug fixes:

BeyondRGB Integration:
- CI workflow: ci-beyondrgb-integration.yml
- Security patches: 5 rounds, 17 vulnerabilities fixed in BeyondRGB backend
  (CWE-416, CWE-78, CWE-89, CWE-22, CWE-502, CWE-798, CWE-326, CWE-614)
- Build scripts: build.ps1 (PowerShell), build guides
- hello-iccdev example (standalone CMake consumer)
- Documentation: build-guide.md, vcpkg-windows-build.md

Upstream Bug Fixes (v2.3.1.6):
- HBO in icAnsiToUtf8 (#740), costFunc (#738)
- SBO in GetValues (#739)
- UB in IccUtil/IccIO/IccUtilXml/IccTagLut (#724-#727)
- NPD in Write (#728), TC in Read (#745)
- DBZ in CalcCoefficients (#754)
- CI improvements (#756)

Validated: cmake build (clang-18, Debug, ASAN), CreateAllProfiles (205),
RunTests, ASAN spot-check (0 errors).

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@xsscx xsscx deleted the fix-ci-scripts branch March 30, 2026 02:35
xsscx pushed a commit that referenced this pull request Mar 30, 2026
demo-rit: BeyondRGB integration + rebase onto master v2.3.1.6
9813733 
Squashed 23 commits from the demo-rit branch, rebased onto latest master
(v2.3.1.6, commit fed8595) incorporating all upstream bug fixes:

BeyondRGB Integration:
- CI workflow: ci-beyondrgb-integration.yml
- Security patches: 5 rounds, 17 vulnerabilities fixed in BeyondRGB backend
  (CWE-416, CWE-78, CWE-89, CWE-22, CWE-502, CWE-798, CWE-326, CWE-614)
- Build scripts: build.ps1 (PowerShell), build guides
- hello-iccdev example (standalone CMake consumer)
- Documentation: build-guide.md, vcpkg-windows-build.md

Upstream Bug Fixes (v2.3.1.6):
- HBO in icAnsiToUtf8 (#740), costFunc (#738)
- SBO in GetValues (#739)
- UB in IccUtil/IccIO/IccUtilXml/IccTagLut (#724-#727)
- NPD in Write (#728), TC in Read (#745)
- DBZ in CalcCoefficients (#754)
- CI improvements (#756)

Validated: cmake build (clang-18, Debug, ASAN), CreateAllProfiles (205),
RunTests, ASAN spot-check (0 errors).

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced Apr 5, 2026
Closed
Merged
xsscx pushed a commit that referenced this pull request Apr 7, 2026
demo-rit: BeyondRGB integration + rebase onto master v2.3.1.6
004d108 
Squashed 23 commits from the demo-rit branch, rebased onto latest master
(v2.3.1.6, commit fed8595) incorporating all upstream bug fixes:

BeyondRGB Integration:
- CI workflow: ci-beyondrgb-integration.yml
- Security patches: 5 rounds, 17 vulnerabilities fixed in BeyondRGB backend
  (CWE-416, CWE-78, CWE-89, CWE-22, CWE-502, CWE-798, CWE-326, CWE-614)
- Build scripts: build.ps1 (PowerShell), build guides
- hello-iccdev example (standalone CMake consumer)
- Documentation: build-guide.md, vcpkg-windows-build.md

Upstream Bug Fixes (v2.3.1.6):
- HBO in icAnsiToUtf8 (#740), costFunc (#738)
- SBO in GetValues (#739)
- UB in IccUtil/IccIO/IccUtilXml/IccTagLut (#724-#727)
- NPD in Write (#728), TC in Read (#745)
- DBZ in CalcCoefficients (#754)
- CI improvements (#756)

Validated: cmake build (clang-18, Debug, ASAN), CreateAllProfiles (205),
RunTests, ASAN spot-check (0 errors).

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChrisCoxArt ChrisCoxArt ChrisCoxArt approved these changes

Assignees

@xsscx xsscx

Labels

PR Pull Request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bisect #739 m_Header.pcs Bisect #708 Testing/

2 participants

@xsscx @ChrisCoxArt