Skip to content

Add icc connect#1001

Merged
xsscx merged 5 commits into
masterfrom
add-icc-connect
May 9, 2026
Merged

Add icc connect#1001
xsscx merged 5 commits into
masterfrom
add-icc-connect

Conversation

@xsscx

@xsscx xsscx commented May 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

PR Summary

#1000

Checklist

  • Built locally with the documented build flow in docs/build.md
  • Ran relevant CTest/profile tests from docs/ctest.md
  • Added or updated regression coverage for behavior changes
  • Checked sanitizer coverage for memory-safety or parser changes
  • Updated documentation for user-visible behavior changes
  • Did not change maintainer-owned workflow, CTest, CPack, sanitizer, release, or security infrastructure unless requested by an iccDEV maintainer
  • New source files include the ICC copyright and BSD 3-Clause license header
  • Code style matches nearby code: 2-space indent, K&R braces, m_ members

@xsscx xsscx requested a review from ChrisCoxArt May 8, 2026 22:47
@xsscx xsscx self-assigned this May 8, 2026
@xsscx xsscx linked an issue May 8, 2026 that may be closed by this pull request
Improve performance and add refactor simpler connection interface for implementers #1000
Closed
@github-actions github-actions Bot added pending CI checks still running Documentation Documentation-only or documentation-related change Tools Command-line tool or GUI tool changes Testing CTest, regression, or test coverage Source C or C++ source code changes Scripts Shell, PowerShell, or repository automation scripts Configuration Repository, CMake, YAML, JSON, or tool configuration Build Build system, CMake, compiler, or packaging ci Continuous integration workflow changes github-actions GitHub Actions workflow or action configuration labels May 8, 2026
@xsscx xsscx added this to the Add icc-connect milestone May 8, 2026
@xsscx xsscx force-pushed the add-icc-connect branch 2 times, most recently from 1fa367d to 522dc68 Compare May 8, 2026 23:16
@xsscx xsscx added the codeql-ready Run the full CodeQL security workflow for this PR label May 8, 2026
github-advanced-security[bot]
github-advanced-security AI found potential problems May 8, 2026
View reviewed changes
Comment thread IccConnect/IccLibConnect/IccConnect.cpp Dismissed
Comment thread IccConnect/IccLibConnect/IccConnect.cpp Dismissed
Comment thread IccConnect/IccLibConnect/IccConnect.cpp Dismissed
Comment thread IccConnect/IccLibConnect/IccConnect.cpp Dismissed
Comment thread IccConnect/IccLibConnect/IccConnect.cpp Dismissed
Comment thread IccConnect/IccLibConnect/IccConnect.cpp Dismissed
Comment thread Tools/CmdLine/IccApplyProfiles/iccApplyProfiles.cpp Dismissed
Comment thread Tools/CmdLine/IccApplyProfiles/iccApplyProfiles.cpp Fixed
Comment thread Tools/CmdLine/IccApplyProfiles/iccApplyProfiles.cpp Fixed
Comment thread IccProfLib/IccObject.h Dismissed
github-advanced-security[bot]
github-advanced-security AI found potential problems May 8, 2026
View reviewed changes
Comment thread Tools/CmdLine/IccApplyProfiles/iccApplyProfiles.cpp Fixed
Comment thread Tools/CmdLine/IccApplyProfiles/iccApplyProfiles.cpp Fixed
@github-actions github-actions Bot added failed One or more CI checks failed and removed pending CI checks still running labels May 8, 2026
@xsscx xsscx added passed All CI checks passed and removed failed One or more CI checks failed labels May 8, 2026
@github-actions github-actions Bot removed the passed All CI checks passed label May 8, 2026
@xsscx xsscx force-pushed the add-icc-connect branch from d801dbe to 90cd4d8 Compare May 9, 2026 01:23
@xsscx xsscx linked an issue May 9, 2026 that may be closed by this pull request
write iccProfileVisualize #994
Closed
@xsscx xsscx removed a link to an issue May 9, 2026
write iccProfileVisualize #994
Closed
@xsscx xsscx added the Merge Ready Approved, mergeable, and all CI checks passed label May 9, 2026
@github-actions github-actions Bot removed the Merge Ready Approved, mergeable, and all CI checks passed label May 9, 2026
@xsscx xsscx force-pushed the add-icc-connect branch from 90cd4d8 to 1282515 Compare May 9, 2026 12:29
@xsscx

xsscx commented May 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

Pre Merge Report

2026-05-09 12:49:30 UTC

  • Final checks in progress
    1. Label System adds visual indicators
    2. Merge Ready label is Source of Truth
    3. Performed restack using skill documentation
    4. Scan-Build and clang-tidy disabled in ci-pr-action
    • For onboarding iccConnect
    • Reduce Maintainer burden
    1. Added CTest Checks
    2. Extend MinGW build for Json & Xml
    • Disable IPO/LTO for MinGW static-only builds

CMake MinGW Mod for LTO in Static Builds

  elseif(MINGW AND ENABLE_STATIC_LIBS AND NOT ENABLE_SHARED_LIBS)
    # MinGW static tool links can fail when executable objects use -flto while
    # iccDEV static archives intentionally disable IPO for native COFF output.
    set(CMAKE_INTERPROCEDURAL_OPTIMIZATION OFF)
    message(STATUS ">>> Link-Time Optimization (LTO) disabled: MinGW static builds require native COFF objects")

Fuzzing Fixes

In .github\ci\ubsan-ignorelist.txt:

# libstdc++ std::string comparison subtracts lengths while ordering object keys.
# This is well-defined unsigned arithmetic, but -fsanitize=integer reports it
# through nlohmann::json's std::map-backed object storage.
[unsigned-integer-overflow]
src:*/bits/basic_string.h

TODO following Merge

  • Bisect - localtime
  • Bisect gmtime
  • CodeQL scanned 137 out of 160 C/C++ files in this invocation
    • UI UX reports C/C++ 157/161 files scanned

Key Indicator

github-actions Bot added passed Merge Ready and removed pending labels 10 minutes ago

Governance Note

The targeting issues Observed were relaxed or disabled to permit grooming & onboarding for iccConnect.

Finalized: 2026-05-09 17:02:19 UTC

@xsscx xsscx force-pushed the add-icc-connect branch 2 times, most recently from 585bece to 70483f2 Compare May 9, 2026 13:09
@github-actions github-actions Bot added passed All CI checks passed Merge Ready Approved, mergeable, and all CI checks passed and removed pending CI checks still running labels May 9, 2026
@xsscx xsscx mentioned this pull request May 9, 2026
Closed
@xsscx xsscx added the Pending Merge Maintainer indicates Merge Pending and Requests No Further Changes label May 9, 2026
@github-actions github-actions Bot added pending CI checks still running passed All CI checks passed Merge Ready Approved, mergeable, and all CI checks passed and removed Merge Ready Approved, mergeable, and all CI checks passed passed All CI checks passed pending CI checks still running labels May 9, 2026
xsscx and others added 5 commits May 9, 2026 11:18
@xsscx xsscx mentioned this pull request Jun 29, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChrisCoxArt ChrisCoxArt ChrisCoxArt approved these changes
+1 more reviewer
@github-advanced-security github-advanced-security[bot] github-advanced-security[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@xsscx xsscx

Labels

Build Build system, CMake, compiler, or packaging ci Continuous integration workflow changes Configuration Repository, CMake, YAML, JSON, or tool configuration Documentation Documentation-only or documentation-related change github-actions GitHub Actions workflow or action configuration Merge Defect Maintainer indicates Merge Defect Merge Ready Approved, mergeable, and all CI checks passed passed All CI checks passed Scripts Shell, PowerShell, or repository automation scripts Source C or C++ source code changes Testing CTest, regression, or test coverage Tools Command-line tool or GUI tool changes

Projects

None yet

Milestone

Add icc-connect

Development

Successfully merging this pull request may close these issues.

Improve performance and add refactor simpler connection interface for implementers

3 participants

@xsscx @ChrisCoxArt @github-advanced-security