Conversation
The ci-latest-release workflow should only build, package, and publish. Test execution belongs in ci-iccdev-tool-tests.yml. Removes CreateAllProfiles, RunTests, and all platform-specific test scripts from the Linux, macOS, and Windows build steps. Fixes #773 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced Apr 5, 2026
xsscx
changed the title
Member
Author
Discussion & Analysis2026-04-05 02:03:25 UTC Task: Code Review of ci-latest-release workflow We can see success as the latest Release is now Commit 9525166 #772 Rolling Latest BuildCommit: 1a57166 Downloads
Install via Package Managers
Auto-published by ci-latest-release on push to issue-773. |
- Fix 7 broken links across docs/ and Tools/ caused by relocating api.md, isapi-instructions.md, iis-isapi.openapi.yaml to Tools/Winnt/IccIisIsapi/ and deleting vcpkg.md - Trim docs/install.md from 189 to 30 lines (remove verbose expected-output dumps that obscure the actual commands) - Condense duplicate Installation section in docs/index.md - Fix stale display text in api.md cross-reference Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Member
Author
MinorUpdates2026-04-05 02:55:11 UTC
Mea Culpa |
- Pin vcpkg clone to builtin-baseline (1940ee7) from vcpkg.json - Pin checkout SHA with version comment (v5.0.0) - Add --clean-after-build to save runner disk space - Add failure diagnostics: show buildtrees log on install failure - Add timeout-minutes: 1 to test executable step - Use Add-Content for PowerShell GITHUB_ENV writes Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Add # v5.0.0 comment to 21 checkout SHA refs across 9 workflows - Add # v5.0.0 (node24) comment to 5 checkout SHA refs in ci-shared-exports - Pin 2 vcpkg clones in ci-shared-exports.yml to builtin-baseline (1940ee7) - Fix ci-vcpkg-ports.yml YAML syntax (uses/with on separate lines, trailing newline) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Add patch #3: disable IccIisIsapi subdirectory (IIS SDK not available in vcpkg, and ISAPI DLLs are not library distribution targets) - Remove stray dependency DLLs (libiconv, libxml2, zlib) that cmake installs alongside tools, conflicting with their own vcpkg ports - Renumber source patches 3-9 to 4-10 Fixes: manifest-test job failure in ci-vcpkg-ports.yml Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
ChrisCoxArt
approved these changes
Apr 5, 2026
…ardening ci-shared-exports.yml (2919->2753 lines): - Remove all CFL/patch infrastructure (clone blocks, patch steps, path prefixes) - Remove dead ICCDEV_REPO/ICCDEV_REF job-level env vars and empty env blocks - Fix CRITICAL expression injection: matrix.os/compiler moved to env vars - Add ref/repository to 6 build job checkout steps - Add governance prologue to 31 run blocks (credential cleanup, pipefail) ci-comprehensive-build-test.yml: - Rename CFL step names to headless CI - Add governance prologue to 19 run blocks ci-code-coverage.yml: - Remove cfl from branch trigger - Fix 30+ expression injections (github.workspace, env.*) - Add governance prologue to 8 run blocks All 3 files: YAML validated, 0 expression injection violations remain. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
ci-shared-exports.yml: - Change iccdev_ref default from 'ci-shared-exports' to 'master' - Update input descriptions (clone -> checkout) - Change push trigger from ci-shared-exports branch to master ci-sanitizer-tests.yml: - Remove stale 'research' and 'workflow-sanity-checks' push branches ci-docker-latest.yml: - Remove stale 'ci-fix-docker' push branch ci-docker-nixos.yml: - Remove stale 'dockerfiles' and 'ci-fix-docker' push branches Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
xsscx
added
Pending Merge
Member
Author
PR Author Comment2026-04-05 04:32:40 UTC iccDLL Server
Web Deployment Choices
|
xsscx
removed
the
Pending Merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
#773