Skip to content

Integrate cardano-api 11.7.0.0 - #1440

Merged
carbolymer merged 1 commit into
masterfrom
mgalazyn/fix/integrate-api-master-202609
Sep 4, 2026
Merged

Integrate cardano-api 11.7.0.0#1440
carbolymer merged 1 commit into
masterfrom
mgalazyn/fix/integrate-api-master-202609

Conversation

@carbolymer

@carbolymer carbolymer commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Context

Integrates the cardano-api 11.7.0.0 release.

Picks up the plutus redeemer pointer indexing fix (cardano-api#1288): proposal pointers now follow the transaction's insertion order and certificate pointers count unwitnessed certificates.

  • Bumps the cardano-api bound to ^>=11.7 and refreshes the CHaP pin (cabal.project index-state and flake.lock).
  • Adapts mkTxCertificatesSbe to the new TxCertificates shape, which no longer pairs each certificate witness with a stake credential (the credential is derived from the certificate).

How to trust this PR

The only code change is in Cardano.CLI.Compatible.Transaction.Run.mkTxCertificatesSbe, following the upstream API change. The rest is dependency pinning. CI builds and tests cover it.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff
  • Changelog fragment added in .changes/

@carbolymer carbolymer self-assigned this Sep 4, 2026
@carbolymer carbolymer changed the title integrate caradno-api master Integrate cardano-api 11.7.0.0 Sep 4, 2026
@carbolymer
carbolymer force-pushed the mgalazyn/fix/integrate-api-master-202609 branch from 8cff8df to 40b00b0 Compare September 4, 2026 07:34
@carbolymer
carbolymer marked this pull request as ready for review September 4, 2026 07:34
Copilot AI lite review requested due to automatic review settings September 4, 2026 07:34
@carbolymer
carbolymer enabled auto-merge September 4, 2026 07:35

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The functional change is small and consistent with the stated upstream API update, with only a minor naming clarity nit identified.

Pull request overview

This PR integrates cardano-api 11.7.0.0 into cardano-cli, updating dependency pins and adapting the transaction certificate construction code to the upstream TxCertificates shape change.

Changes:

  • Bump cardano-api dependency bound to ^>=11.7.
  • Refresh CHaP pins (cabal.project index-state and flake.lock).
  • Update mkTxCertificatesSbe to construct TxCertificates with the new witness shape.
File summaries
File Description
flake.lock Updates CHaP pin revision/hash to align Nix inputs with the new dependency set.
cardano-cli/src/Cardano/CLI/Compatible/Transaction/Run.hs Adapts mkTxCertificatesSbe to the updated TxCertificates witness representation.
cardano-cli/cardano-cli.cabal Bumps the cardano-api version bound to ^>=11.7.
cabal.project Updates CHaP index-state to a newer snapshot.
.changes/20260904_074500_cardano-cli_mgalazyn_integrate_cardano_api_11_7_0_0.yml Adds a changelog fragment for the dependency update.
Review details
  • Files reviewed: 4/5 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread cardano-cli/src/Cardano/CLI/Compatible/Transaction/Run.hs Outdated
@carbolymer
carbolymer force-pushed the mgalazyn/fix/integrate-api-master-202609 branch 2 times, most recently from 6ecf3ce to b467024 Compare September 4, 2026 07:40
Bump the cardano-api bound to ^>=11.7 and refresh the CHaP pin.
Adapt mkTxCertificatesSbe to the new TxCertificates shape, which no longer
pairs each certificate witness with a stake credential.
@carbolymer
carbolymer force-pushed the mgalazyn/fix/integrate-api-master-202609 branch from b467024 to 59802ec Compare September 4, 2026 07:43

@palas palas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@carbolymer
carbolymer added this pull request to the merge queue Sep 4, 2026
Merged via the queue into master with commit d98f111 Sep 4, 2026
25 checks passed
@carbolymer
carbolymer deleted the mgalazyn/fix/integrate-api-master-202609 branch September 4, 2026 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants