Skip to content

Conversation

@teodanciu
Copy link
Contributor

@teodanciu teodanciu commented May 2, 2025

Description

These are changes to be merged in my other branch, refactor-pparams.

The reason for this structure with two PRs is as follows:

  1. refactor-pparams brand and PR just adds functions equivalent to the CBOR, JSON and Plutus (de)serializers, and also adds tests to check the equivalence, but doesn't actually replace the instances. So that both versions (the current (de)serializers) and the new versions exists at the same time and their equivalence is checked by CI by running these tests I added

  2. we want the final changes to replace the instances with the functions I added in refactor-pparams, and this is what this PR does: defining generic instances in EraPParams and using them in the instances of each era. Also removing the temporary tests.

Checklist

  • Commits in meaningful sequence and with useful messages.
  • Tests added or updated when needed.
  • CHANGELOG.md files updated for packages with externally visible changes.
    NOTE: New section is never added with the code changes. (See RELEASING.md).
  • Versions updated in .cabal and CHANGELOG.md files when necessary, according to the
    versioning process.
  • Version bounds in .cabal files updated when necessary.
    NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
  • Code formatted (use scripts/fourmolize.sh).
  • Cabal files formatted (use scripts/cabal-format.sh).
  • CDDL files are up to date (use scripts/gen-cddl.sh)
  • hie.yaml updated (use scripts/gen-hie.sh).
  • Self-reviewed the diff.

@teodanciu teodanciu force-pushed the td/replace-pparam-serializers branch from 7602c04 to 58e2a05 Compare May 2, 2025 17:35
@teodanciu teodanciu force-pushed the td/replace-pparam-serializers branch from 58e2a05 to 5f27ed1 Compare May 6, 2025 12:41
@teodanciu teodanciu force-pushed the td/refactor-pparams branch from d3e678c to b8004fc Compare May 6, 2025 12:42
@teodanciu teodanciu force-pushed the td/replace-pparam-serializers branch from 5f27ed1 to 609e160 Compare May 6, 2025 16:26
@teodanciu teodanciu force-pushed the td/refactor-pparams branch from b8004fc to 563aa91 Compare May 7, 2025 08:18
@teodanciu teodanciu force-pushed the td/replace-pparam-serializers branch from 609e160 to 5b81398 Compare May 7, 2025 08:19
@teodanciu teodanciu force-pushed the td/replace-pparam-serializers branch from 5b81398 to aa01745 Compare May 7, 2025 10:00
@teodanciu
Copy link
Contributor Author

Superseded by #5027

@teodanciu teodanciu closed this May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants