-
Notifications
You must be signed in to change notification settings - Fork 172
[wip] Replace era-specific PParams serializers with instances defined in EraPParams
#5019
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7602c04 to
58e2a05
Compare
teodanciu
commented
May 2, 2025
teodanciu
commented
May 2, 2025
58e2a05 to
5f27ed1
Compare
d3e678c to
b8004fc
Compare
5f27ed1 to
609e160
Compare
b8004fc to
563aa91
Compare
609e160 to
5b81398
Compare
5b81398 to
aa01745
Compare
Contributor
Author
|
Superseded by #5027 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These are changes to be merged in my other branch, refactor-pparams.
The reason for this structure with two PRs is as follows:
refactor-pparams brand and PR just adds functions equivalent to the CBOR, JSON and Plutus (de)serializers, and also adds tests to check the equivalence, but doesn't actually replace the instances. So that both versions (the current (de)serializers) and the new versions exists at the same time and their equivalence is checked by CI by running these tests I added
we want the final changes to replace the instances with the functions I added in
refactor-pparams, and this is what this PR does: defining generic instances inEraPParamsand using them in the instances of each era. Also removing the temporary tests.Checklist
CHANGELOG.mdfiles updated for packages with externally visible changes.NOTE: New section is never added with the code changes. (See RELEASING.md).
.cabalandCHANGELOG.mdfiles when necessary, according to theversioning process.
.cabalfiles updated when necessary.NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
scripts/fourmolize.sh).scripts/cabal-format.sh).scripts/gen-cddl.sh)hie.yamlupdated (usescripts/gen-hie.sh).