Conversation
mkoura
requested changes
Dec 16, 2025
cardano_node_tests/tests/tests_conway/test_treasury_withdrawals.py
Outdated
Show resolved
Hide resolved
cardano_node_tests/tests/tests_conway/test_treasury_withdrawals.py
Outdated
Show resolved
Hide resolved
cardano_node_tests/tests/tests_conway/test_treasury_withdrawals.py
Outdated
Show resolved
Hide resolved
mkoura
force-pushed
the
update-compatible-tests
branch
3 times, most recently
from
0ec142e to
6f1536f
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Conway-era negative/compatibility tests to use cluster.g_compatible helpers across multiple legacy eras, ensuring legacy-era artifacts are rejected when submitted in Conway.
Changes:
- Parameterize several negative tests over legacy eras (Shelley → Babbage) and generate artifacts via
cluster.g_compatible.<era>. - Refactor MIR certificate test to build/sign via compatible-era transaction helpers and assert Conway submission failure.
- Add new negative coverage for mixing legacy artifacts with Conway transactions (pool registration, stake registration/delegation, mixed governance/certs).
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| cardano_node_tests/tests/tests_conway/test_treasury_withdrawals.py | Refactors MIR certificate negative test to use compatible era APIs and expands across legacy eras. |
| cardano_node_tests/tests/tests_conway/test_pparam_update.py | Generates legacy update proposals via compatible CLI across eras and asserts Conway rejection. |
| cardano_node_tests/tests/tests_conway/test_conway.py | Adds negative test mixing legacy governance artifact with Conway vote delegation cert. |
| cardano_node_tests/tests/test_pools.py | Adds negative test for legacy pool registration submission in Conway; adjusts pool user funding. |
| cardano_node_tests/tests/test_delegation.py | Adds negative test that legacy delegation certs are rejected in Conway. |
| cardano_node_tests/tests/test_addr_registration.py | Adds negative test that legacy stake registration certs are rejected in Conway. |
| cardano_node_tests/tests/issues.py | Adds blocker metadata for cardano-cli issue #1347. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
mkoura
force-pushed
the
update-compatible-tests
branch
from
6f1536f to
562682b
Compare
- Add negative tests to ensure legacy stake address registration, delegation, pool registration, governance proposals, and MIR certificates are rejected in Conway. - Parametrize tests across all compatible legacy eras (Shelley, Allegra, Mary, Alonzo, Babbage). - Expect transaction submission to fail with a "TextEnvelope type error" or era mismatch error. - Remove obsolete tests for legacy proposal build with Conway CLI. - Add issue marker for cli issue 1347 (Compat stake reg cert accepted without deposit amount).
mkoura
force-pushed
the
update-compatible-tests
branch
from
562682b to
fff6cf5
Compare
mkoura
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update compatible tests