Define snapshot versioning and metadata #442
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorisdral
requested review from
dcoutts,
mheinzel and
recursion-ninja
as code owners
jorisdral
changed the title
mheinzel
reviewed
Oct 28, 2024
jorisdral
force-pushed
the
jdral/snapshot-metadata
branch
from
642a493 to
6e5b3ae
Compare
jorisdral
force-pushed
the
jdral/snapshot-metadata
branch
from
6e5b3ae to
a84ca60
Compare
mheinzel
approved these changes
Nov 5, 2024
jorisdral
force-pushed
the
jdral/snapshot-metadata
branch
from
e549686 to
9a9adc5
Compare
dcoutts
reviewed
Nov 8, 2024
| import System.FS.BlockIO.API (HasBlockIO) | ||
|
|
||
| -- | Custom text to include in a snapshot file | ||
| newtype SnapshotLabel = SnapshotLabel Text |
Collaborator
There was a problem hiding this comment.
A newtype is good but do we need Text here? This is the only thing that pulls in the extra text package dep.
Collaborator
There was a problem hiding this comment.
Never mind, adding the dep on cborg in #443 adds text anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the snapshot versioning scheme is to your liking, then we should probably also make it part of the PR checklist to update version numbers in case there are changes to the snapshot format.