-
Notifications
You must be signed in to change notification settings - Fork 9
Encoding and decoding of snapshot metadata as CBOR #443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a8acd3b to
1d182b6
Compare
642a493 to
6e5b3ae
Compare
mheinzel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable, but maybe @dcoutts should also take a quick look.
1d182b6 to
cf0356d
Compare
6e5b3ae to
a84ca60
Compare
cf0356d to
ad4f53d
Compare
e549686 to
9a9adc5
Compare
f599dbf to
c6cb049
Compare
|
The explanation of major/minor has gone after the rebase. I was drafting an alternative. I think the precision doesn't really aid comprehension here. How about: |
|
@dcoutts done |
We also add roundtrip tests for each type in the hierarchy of snapshot metadata.
076dfaa to
038cad3
Compare
mheinzel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that's better 👍
| -- would lead to errors when loading an older snapshot, then the major version | ||
| -- should be increased as well. | ||
| data SnapshotVersion = V0_0 | ||
| -- A snapshot format version has one component: a version number @x@. A single |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A simpler way of saying this would be "a snapshot format version is a number", maybe also mentioning they're consecutive and increasing?
| -- is not provided at all: snapshots with a later major version than the current | ||
| -- version for the library release will always fail. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| -- is not provided at all: snapshots with a later major version than the current | |
| -- version for the library release will always fail. | |
| -- is not provided at all: snapshots with a later version than the current | |
| -- version for the library release will always fail. |
dcoutts
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
… version number. We now have a single version number. Backwards compatibility is guaranteed for at least 1 version, and forwards compatibility is not guaranteed at all.
038cad3 to
5ba267d
Compare
No description provided.