Add n-way table unions #489
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
This is a WIP, so not reviewable just yet |
jorisdral
force-pushed
the
jdral/n-way-unions
branch
from
0b7b775 to
d18d2fb
Compare
jorisdral
requested review from
dcoutts,
mheinzel,
recursion-ninja and
wenkokke
as code owners
jorisdral
force-pushed
the
jdral/n-way-unions
branch
from
d18d2fb to
d5c8ba4
Compare
Collaborator
Author
|
Should be ready for review now! Note that this PR is built on top of #486. |
dcoutts
reviewed
Dec 10, 2024
Collaborator
dcoutts
left a comment
dcoutts
left a comment
There was a problem hiding this comment.
👍 looks fine, though seems to me there's no need to exclude the trivial case of n == 1.
dcoutts
approved these changes
Dec 10, 2024
Collaborator
dcoutts
left a comment
dcoutts
left a comment
There was a problem hiding this comment.
oops, meant to approve, not just comment.
Originally, I had put underscores in the field names so that they wouldn't show up in "unused identifier" compiler errors. But, since they're exported now anyway, we can get rid of the underscores
jorisdral
force-pushed
the
jdral/n-way-unions
branch
from
d5c8ba4 to
ad5d621
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
n-way table unions should be more performant than repeated 2-way unions