Unify class-based tests #486
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
This is a WIP, so not yet ready for review |
The intent is to convert the tests in this module to use the unified class instead of the `Normal` class.
Having renamed the relevant module in the previous commit, we now switch to using the unified class instead of the `Normal` class.
The `Normal` class-based tests have been converted to use the unified class, but there are still two tests for the `Monoidal` class that we can port to the unified class-based tests.
Since switching to using the unified class everywhere in our tests, these modules have now become obsolete.
The unified model can now use the `LookupResult`, `QueryResult` and `Update` types that are defined in the unified public API.
jorisdral
force-pushed
the
jdral/unified-class-tests
branch
from
25de29a to
aa22af7
Compare
jorisdral
requested review from
dcoutts,
mheinzel,
recursion-ninja and
wenkokke
as code owners
Collaborator
Author
|
Ready for review now! |
jorisdral
force-pushed
the
jdral/unified-class-tests
branch
from
e4864da to
0dec722
Compare
Merged
mheinzel
reviewed
Dec 6, 2024
mheinzel
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce duplication by using the unified class everywhere in our tests, which means we can remove the
NormalandMonoidalclasses altogether.