refactor(aggregator): remove deprecated configuration field from DependencyContainer - #2385
Merged
Alenar merged 3 commits intoMar 24, 2025
Conversation
…_state_from_fixture` This remove the usages of the only configuration field of the dependency container.
…ependencyContainer`
Alenar
force-pushed
the
djo/2384/aggregator/remove_configuration_from_dep_container
branch
from
March 24, 2025 17:47
b7cbc14 to
378b75b
Compare
* mithril-aggregator from `0.7.21` to `0.7.22`
Alenar
deleted the
djo/2384/aggregator/remove_configuration_from_dep_container
branch
March 24, 2025 18:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Content
This PR remove the deprecated
configurationfield fromDependencyContainer.This field was problematic as the
Configurationstructure is not fully validated, meaning that consumer of this attribute may have to re-validate the fields they needed, something not necessary as the field should have been validated when constructing the dependency builder.Also, leaving this field as is would complicate #2384 work as the
Configurationstructure will likely not be used anymore in theDependenciesBuilder(used to build the container).Pre-submit checklist
Issue(s)
Relates to #2384