Skip to content

ci: add --locked to clippy in check step#2573

Merged
Alenar merged 1 commit into
mainfrom
djo/2549/ensure-cargo-lock-up-to-date
Jun 16, 2025
Merged

ci: add --locked to clippy in check step#2573
Alenar merged 1 commit into
mainfrom
djo/2549/ensure-cargo-lock-up-to-date

Conversation

@Alenar

@Alenar Alenar commented Jun 13, 2025

Copy link
Copy Markdown
Collaborator

Content

This PR includes add --locked to clippy in check step, this will make the CI fail if Cargo.lock was not updated after a change in a Cargo.toml such as a version bump.

Pre-submit checklist

  • Branch
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • All check jobs of the CI have succeeded
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • No new TODOs introduced

Issue(s)

Closes #2549

@Alenar Alenar self-assigned this Jun 13, 2025
@Alenar Alenar added the CI/CD 🏭 CI/CD label Jun 13, 2025
@github-actions

github-actions Bot commented Jun 13, 2025

Copy link
Copy Markdown

Test Results

    3 files  ±0     88 suites  ±0   14m 20s ⏱️ -19s
1 999 tests ±0  1 999 ✅ ±0  0 💤 ±0  0 ❌ ±0 
3 523 runs  ±0  3 523 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit ac42323. ± Comparison against base commit e04d9b1.

♻️ This comment has been updated with latest results.

@Alenar
Alenar temporarily deployed to testing-preview June 13, 2025 13:28 — with GitHub Actions Inactive
@Alenar
Alenar force-pushed the djo/2549/ensure-cargo-lock-up-to-date branch 3 times, most recently from 2eb110c to 55caf0f Compare June 13, 2025 14:04

@jpraynaud jpraynaud left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Alenar
Alenar temporarily deployed to testing-preview June 13, 2025 14:13 — with GitHub Actions Inactive
This will make the CI fail if the `Cargo.lock` was not updated after a
change in a `Cargo.toml` such as a version bump.
@Alenar
Alenar force-pushed the djo/2549/ensure-cargo-lock-up-to-date branch from 55caf0f to ac42323 Compare June 13, 2025 14:29
@Alenar
Alenar temporarily deployed to testing-preview June 13, 2025 14:37 — with GitHub Actions Inactive

@turmelclem turmelclem left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Alenar
Alenar merged commit bc83454 into main Jun 16, 2025
38 checks passed
@Alenar
Alenar deleted the djo/2549/ensure-cargo-lock-up-to-date branch June 16, 2025 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ensure Cargo.lock file is updated in the CI

4 participants