feat: enhance tools utxo-hd snapshot-converter Mithril client CLI command

[dlachaume]

Content

This PR includes improvements to the tools utxo-hd snapshot-converter Mithril client CLI command, including:

• Making the --cardano-network parameter optional and deprecated, as the value can be retrieved from the protocolMagicId file
• Implementing fallback logic: the tool now attempts to convert the latest ledger state snapshot, and falls back to the second latest in case of a conversion error

Output example with fallback:

Downloading Cardano node distribution for tag: 'latest'...
Distribution downloaded successfully. Archive location: /Users/dl/db/tmp/cardano-node-distribution/cardano-node-10.4.1-macos.tar.gz
Unpacking distribution from archive: /Users/dl/db/tmp/cardano-node-distribution/cardano-node-10.4.1-macos.tar.gz
Distribution unpacked successfully to: /Users/dl/db/tmp/cardano-node-distribution
Converting ledger state snapshot to 'LMDB' flavor
Converting '/Users/dl/db/ledger/81343798' (attempt #1)
Loading snapshot...
snapshot-converter: The input snapshot does not seem to correspond to the input format:
        Mem
        The provided path DOES NOT contain a "state" file
Failed to convert ledger state snapshot '/Users/dl/db/ledger/81343798': Failure while running snapshot-converter binary, exited with status code: "1"
Converting '/Users/dl/db/ledger/81340997' (attempt #2)
Loading snapshot...
Loaded snapshot
Writing snapshot...
Written snapshot
Successfully converted ledger state snapshot: '/Users/dl/db/ledger/81340997'
Snapshot location: /Users/dl/db/tmp/snapshots/81340997_lmdb

Pre-submit checklist

• Branch
  • Tests are provided (if possible)
  • Crates versions are updated (if relevant)
  • CHANGELOG file is updated (if relevant)
  • Commit sequence broadly makes sense
  • Key commits have useful messages
• PR
  • All check jobs of the CI have succeeded
  • Self-reviewed the diff
  • Useful pull request description
  • Reviewer requested
• Documentation
  • Update README file (if relevant)
  • Update documentation website (if relevant)
  • Add dev blog post (if relevant)
  • Add ADR blog post or Dev ADR entry (if relevant)
  • No new TODOs introduced

Issue(s)

Closes #2571

[github-actions]

Test Results

    3 files  ± 0     88 suites  ±0   13m 53s ⏱️ +15s
2 032 tests +10  2 032 ✅ +10  0 💤 ±0  0 ❌ ±0 
3 593 runs  +30  3 593 ✅ +30  0 💤 ±0  0 ❌ ±0 

Results for commit 26fba87. ± Comparison against base commit 95ee801.

This pull request removes 5 and adds 15 tests. Note that renamed tests count towards both.

mithril-client-cli ‑ commands::tools::snapshot_converter::tests::find_oldest_ledger_state_snapshot::finds_ledger_state_snapshot_with_lowest_slot_number
mithril-client-cli ‑ commands::tools::snapshot_converter::tests::find_oldest_ledger_state_snapshot::get_sorted_snapshot_dirs_returns_sorted_valid_directories
mithril-client-cli ‑ commands::tools::snapshot_converter::tests::find_oldest_ledger_state_snapshot::ignores_non_numeric_and_non_directory_entries
mithril-client-cli ‑ commands::tools::snapshot_converter::tests::find_oldest_ledger_state_snapshot::returns_error_if_no_valid_snapshot_found
mithril-client-cli ‑ commands::tools::snapshot_converter::tests::find_oldest_ledger_state_snapshot::returns_snapshot_when_only_one_valid_directory

mithril-client-cli ‑ commands::tools::snapshot_converter::tests::detect_cardano_network::detects_mainnet
mithril-client-cli ‑ commands::tools::snapshot_converter::tests::detect_cardano_network::detects_preprod
mithril-client-cli ‑ commands::tools::snapshot_converter::tests::detect_cardano_network::detects_preview
mithril-client-cli ‑ commands::tools::snapshot_converter::tests::detect_cardano_network::fails_on_invalid_network
mithril-client-cli ‑ commands::tools::snapshot_converter::tests::detect_cardano_network::fails_when_protocol_magic_id_file_is_empty
mithril-client-cli ‑ commands::tools::snapshot_converter::tests::detect_cardano_network::fails_when_protocol_magic_id_file_is_missing
mithril-client-cli ‑ commands::tools::snapshot_converter::tests::snapshot_conversion_fallback::conversion_fails_if_all_attempts_fail
mithril-client-cli ‑ commands::tools::snapshot_converter::tests::snapshot_conversion_fallback::conversion_falls_back_if_first_conversion_fails
mithril-client-cli ‑ commands::tools::snapshot_converter::tests::snapshot_conversion_fallback::conversion_succeed_and_is_called_once_if_first_conversion_succeeds
mithril-client-cli ‑ commands::tools::snapshot_converter::tests::snapshots_indexing::get_sorted_snapshot_dirs_returns_sorted_valid_directories
…

♻️ This comment has been updated with latest results.

[jpraynaud]

LGTM 👍

[turmelclem]

LGTM