Skip to content

chore: replace serde_yaml with serde_yml#2649

Merged
dlachaume merged 2 commits into
mainfrom
dlachaume/2639/replace-serde-yaml-unmaintained-crate
Jul 24, 2025
Merged

chore: replace serde_yaml with serde_yml#2649
dlachaume merged 2 commits into
mainfrom
dlachaume/2639/replace-serde-yaml-unmaintained-crate

Conversation

@dlachaume

@dlachaume dlachaume commented Jul 23, 2025

Copy link
Copy Markdown
Contributor

Content

This PR includes the replacement of serde_yaml by serde_yml in mithril-build-script and mithril-api-spec, as serde_yaml is no longer maintained.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • All check jobs of the CI have succeeded
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)
    • Add ADR blog post or Dev ADR entry (if relevant)
    • No new TODOs introduced

Issue(s)

Closes #2639

@dlachaume dlachaume self-assigned this Jul 23, 2025
@github-actions

github-actions Bot commented Jul 23, 2025

Copy link
Copy Markdown

Test Results

    4 files  ±0    154 suites  ±0   22m 3s ⏱️ -43s
2 118 tests ±0  2 118 ✅ ±0  0 💤 ±0  0 ❌ ±0 
6 466 runs  ±0  6 466 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 1ec2bbf. ± Comparison against base commit b76f911.

♻️ This comment has been updated with latest results.

@dlachaume
dlachaume temporarily deployed to testing-preview July 23, 2025 12:49 — with GitHub Actions Inactive
@turmelclem
turmelclem self-requested a review July 24, 2025 08:08

@turmelclem turmelclem left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✨

* mithril-build-script from `0.2.25` to `0.2.26`
* mithril-api-spec from `0.1.2` to `0.1.3`
@dlachaume
dlachaume temporarily deployed to testing-preview July 24, 2025 08:25 — with GitHub Actions Inactive
@dlachaume
dlachaume merged commit 377d7f6 into main Jul 24, 2025
70 of 71 checks passed
@dlachaume
dlachaume deleted the dlachaume/2639/replace-serde-yaml-unmaintained-crate branch July 24, 2025 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace serde_yaml unmaintained crate

3 participants