Skip to content

fix: do not build rug when targeting musl env#2735

Merged
jpraynaud merged 3 commits into
mainfrom
jpraynaud/fix-rug-static-compilation
Oct 13, 2025
Merged

fix: do not build rug when targeting musl env#2735
jpraynaud merged 3 commits into
mainfrom
jpraynaud/fix-rug-static-compilation

Conversation

@jpraynaud

@jpraynaud jpraynaud commented Oct 10, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Content

This PR includes a fix that prevents building the client library with the num-integer-backend without embedding rug (which is not compatible) when targeting musl.

Pre-submit checklist

  • Branch
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • All check jobs of the CI have succeeded
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

@jpraynaud jpraynaud self-assigned this Oct 10, 2025
@github-actions

github-actions Bot commented Oct 10, 2025 •
edited
Loading

Copy link
Copy Markdown

Test Results

    4 files  ±0    164 suites  ±0   22m 42s ⏱️ -5s
2 204 tests ±0  2 204 ✅ ±0  0 💤 ±0  0 ❌ ±0 
6 787 runs  ±0  6 787 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 9ce17df. ± Comparison against base commit d671644.

♻️ This comment has been updated with latest results.

@jpraynaud jpraynaud changed the title fix: do not build 'rug' when targetting 'musl' env fix: do not build rug when targeting musl env Oct 10, 2025
turmelclem
turmelclem approved these changes Oct 13, 2025
View reviewed changes

@turmelclem turmelclem left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jpraynaud
jpraynaud force-pushed the jpraynaud/fix-rug-static-compilation branch from 7e509c4 to b79623b Compare October 13, 2025 07:43
@jpraynaud
chore: upgrade crate versions
9ce17df 
* mithril-stm from `0.5.4` to `0.5.5`
@jpraynaud
jpraynaud force-pushed the jpraynaud/fix-rug-static-compilation branch from b79623b to 9ce17df Compare October 13, 2025 07:53
@jpraynaud
jpraynaud merged commit b7be57f into main Oct 13, 2025
41 checks passed
@jpraynaud
jpraynaud deleted the jpraynaud/fix-rug-static-compilation branch October 13, 2025 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Alenar Alenar Alenar approved these changes
@turmelclem turmelclem turmelclem approved these changes

Assignees

@jpraynaud jpraynaud

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jpraynaud @Alenar @turmelclem